fix(router): scroll back to the hash anchor even if it is already selected #2265
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchzh3473
changed the title
lchzh3473
changed the title
brc-dd
approved these changes
Apr 21, 2023
|
Hey can you run |
Even if the hash is equal to the current hash, we still need to scroll it to the corresponding anchor.
OK, I've run pnpm format and committed the changes. |
brc-dd
changed the title
brc-dd
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
即使hash与当前hash相等，我们仍然需要将其滚动到对应锚点。
否则当我们点击锚点后手动滚回原位，再次点击相同的锚点时将没有任何反应。
Even if the hash is equal to the current hash, we still need to scroll it to the corresponding anchor.
Otherwise, when we click on the anchor and then manually roll back and click on the same anchor again, there will be no response.