Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hmr): throw non-standard error info causes logical error #19776

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix(hmr): throw non-standard error info causes logical error #19776

merged 1 commit into from
Apr 3, 2025

Conversation

btea
Copy link
Collaborator

@btea btea commented Apr 2, 2025

Description

fix #19709

@sapphi-red sapphi-red added feat: hmr p2-edge-case Bug, but has workaround or limited in scope (priority) labels Apr 3, 2025
sapphi-red
sapphi-red approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit 6b648c7 into vitejs:main Apr 3, 2025
25 of 26 checks passed
@btea btea deleted the fix/hmr-throw-non-standard-error branch April 3, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: hmr p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetchUpdate assumes import error to be instanceof Error
3 participants
@btea @hi-ogawa @sapphi-red