fix(css): scoped css order with non-scoped css #19678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
sapphi-red
added
feat: css
p3-downstream-blocker
|
/ecosystem-ci run |
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Ran ecosystem CI on ✅ histoire, rakkas, analogjs, qwik, previewjs, astro, nuxt, ladle, marko, vite-setup-catalogue, waku, sveltekit, laravel, vitest, quasar, vite-environment-examples, vite-plugin-vue, vite-plugin-react, react-router, vite-plugin-cloudflare, vite-plugin-react-swc, vitepress, unocss, vite-plugin-svelte, vite-plugin-pwa, vike, vuepress, storybook |
bluwy
previously approved these changes
Mar 19, 2025
patak-dev
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the implementation of
cssScopeTosupport to the one proposed in #16058 from #19418.The implementation in #19418 has a upside of a better chunking behavior, but had a downside of not preserving the style order when a single module has both scoped and non-scoped styles.
refs https://discord.com/channels/804011606160703521/804439875226173480/1349606289252028418
refs withastro/astro#13420