Skip to content

Commit 0d906d9

Browse files
nathanchancevijaymalav564
authored andcommitted
ANDROID: generate_initcall_order.pl: Use two dash long options for llvm-nm
Commit 96e9bc424475 ("[llvm-nm] Remove one-dash long options except -arch") in LLVM removed the one dash long options, which causes this script to fail and initcalls not to get ordered properly, which manifests as kernels crashing durin boot. Use the two dash long options as the LLVM commit mentions that the documentation and help text have always shown them over the one dash long versions. This is not an issue with the mainline LTO series as it used two dash long options. Change-Id: Iaef9f96af1d75b54eabc4bba38d2a3a58c3c2209 Fixes: 93185a915514 ("ANDROID: init: ensure initcall ordering with LTO") Link: llvm/llvm-project@96e9bc4 Link: https://github.com/ClangBuiltLinux/continuous-integration2/runs/3129736977?check_suite_focus=true Link: https://github.com/ClangBuiltLinux/continuous-integration2/runs/3129775494?check_suite_focus=true Link: https://github.com/ClangBuiltLinux/continuous-integration2/runs/3129863440?check_suite_focus=true Signed-off-by: Nathan Chancellor <nathan@kernel.org>
1 parent ddcf4b2 commit 0d906d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/generate_initcall_order.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ sub find_initcalls {
4141

4242
die "$0: object file $object doesn't exist?" if (! -f $object);
4343

44-
open(my $fh, "\"$nm\" -just-symbol-name -defined-only \"$object\" 2>/dev/null |")
44+
open(my $fh, "\"$nm\" --just-symbol-name --defined-only \"$object\" 2>/dev/null |")
4545
or die "$0: failed to execute \"$nm\": $!";
4646

4747
my $initcalls = {};

0 commit comments

Comments
 (0)