-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NextResponse.redirect() behaves incorrectly when redirecting from subdomain route to apex domain route #75173
Comments
Thanks for the reply. Those links seem to pertain to page-based redirects. The issue however is within middleware. eg: You reference providing a interface ResponseInit extends globalThis.ResponseInit {
nextConfig?: {
basePath?: string;
i18n?: I18NConfig;
trailingSlash?: boolean;
};
url?: string;
} however, providing: return NextResponse.redirect(
new URL("http://example.test:3000/login"),
{ nextConfig: { basePath: "http://example.test:3000/" } }
); has the same result. For inline reference, here is the import { NextRequest, NextResponse } from "next/server";
export const config = {
matcher: [
/*
* Match all paths except for:
* 1. /api routes
* 2. /_next (Next.js internals)
* 3. /_static (inside /public)
* 4. all root files inside /public (e.g. /favicon.ico)
*/
"/((?!api/|_next/|_static/|_vercel|[\\w-]+\\.\\w+).*)",
],
};
export default async function middleware(req: NextRequest) {
const host = req.headers.get("host") || "";
const [subdomain, ...rest] = host.split(".");
const hasSubdomain = rest.length >= 2;
// check if this came in on a subdomain
if (hasSubdomain) {
console.log({ subdomain, nextUrl: req.nextUrl });
// specifically redirect the "shouldredirect" subdomain as a demonstration
if (req.nextUrl.pathname.startsWith("/shouldredirect")) {
// explicitly redirect to the login page with a fully defined URL
const rootLoginPage = new URL("http://example.test:3000/login");
console.log(
`redirecting to root login page - ${rootLoginPage.toString()}`
);
return NextResponse.redirect(rootLoginPage); // <-- actually redirects to http://foo.example.test:3000/login
}
// otherwise, rewrite the subdomain to the /[domain] dynamic route
return NextResponse.rewrite(
new URL(`/${subdomain}${req.nextUrl.pathname}`, req.url)
);
}
// handle all other requests
return NextResponse.next();
} |
Link to the code that reproduces this issue
https://github.com/bentron2000/next-response-bug-report
To Reproduce
Set
/etc/hosts
:Install Packages:
Start Server:
Then Navigate to the following link and observe the result.
'http://foo.example.test:3000/shouldredirect'
Current vs. Expected behavior
When you navigate to the 'http://foo.example.test:3000/shouldredirect'
Middleware should select for this route and redirect to the apex domain '/login' page
Expected Result:
Redirect to : 'http://example.test:3000/login' -> 'Hooray - we redirected properly'
Actual Result:
Redirect to : 'http://foo.example.test:3000/login' -> 'Should not be redirected here'
Provide environment information
Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 24.2.0: Fri Dec 6 18:51:28 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T8112 Available memory (MB): 16384 Available CPU cores: 8 Binaries: Node: 20.10.0 npm: 10.8.1 Yarn: 1.22.22 pnpm: 9.15.0 Relevant Packages: next: 15.2.0-canary.19 // Latest available version is detected (15.2.0-canary.19). eslint-config-next: N/A react: 19.0.0 react-dom: 19.0.0 typescript: 5.7.3 Next.js Config: output: N/A
Which area(s) are affected? (Select all that apply)
Middleware
Which stage(s) are affected? (Select all that apply)
next dev (local)
Additional context
Minimal demo of possible middleware
NextResponse.redirect()
BugDemonstrates that NextResponse.redirect is not obeying explicit urls when redirecting from a subdomain
foo.example.test
to the apex domainexample.test
In this example, middleware has been set to catch a specific subdomain route and to redirect it to an explicitly set route on the apex domain
'http://foo.example.test:3000/shouldredirect' -> 'http://example.test:3000/login'
This does not happen - it redirects to the same path but on the subdomain.
To Reproduce
Set
/etc/hosts
:Install Packages:
Start Server:
Then Navigate to the following link and observe the result.
'http://foo.example.test:3000/shouldredirect'
Middleware should select for this route and redirect to the apex domain '/login' page
Expected Result:
Redirect to : 'http://example.test:3000/login' -> 'Hooray - we redirected properly'
Actual Result:
Redirect to : 'http://foo.example.test:3000/login' -> 'Should not be redirected here'
The text was updated successfully, but these errors were encountered: