Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TakeShape example readme is out of date #38210

Closed
1 task done
S3Prototype opened this issue Jun 30, 2022 · 3 comments
Closed
1 task done

TakeShape example readme is out of date #38210

S3Prototype opened this issue Jun 30, 2022 · 3 comments
Labels
bug Issue was opened via the bug report template. examples Issue was opened via the examples template. stale The issue has not seen recent activity.

Comments

@S3Prototype
Copy link
Contributor

S3Prototype commented Jun 30, 2022

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

The module 'react-dom' was not found. Next.js requires that 
you include it in 'dependencies' of your 'package.json'. To 
add it, run 'npm install react-dom'
(node:11140) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, realpath 'P:\NodeProjects\TakeShape\External Repos\next.js\info'
    at Function.realpathSync.native (fs.js:1855:3)
    at Object.getProjectDir (C:\Users\user\AppData\Roaming\npm\node_modules\next\dist\lib\get-project-dir.js:39:46)    at nextDev (C:\Users\user\AppData\Roaming\npm\node_modules\next\dist\cli\next-dev.js:84:37)
    at C:\Users\user\AppData\Roaming\npm\node_modules\next\dist\bin\next:119:34      
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:11140) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:11140) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.      

Which example does this report relate to?

cms-takeshape https://github.com/vercel/next.js/tree/canary/examples/cms-takeshape

What browser are you using? (if relevant)

N/A

How are you deploying your application? (if relevant)

N/A

Describe the Bug

The readme is outdated. Old terminology and instructions needs to be updated. I'm the technical writer for TakeShape.

Expected Behavior

Old terminology should be updated. Words like Content Type should be changed to Shape. Certain instructions no longer match the TakeShape UI.

To Reproduce

It's an issue in the readme.

@S3Prototype S3Prototype added the bug Issue was opened via the bug report template. label Jun 30, 2022
@jankaifer
Copy link
Contributor

Hey, sorry for taking too long to follow up here.
We would love to merge your PR.

@jankaifer jankaifer added the examples Issue was opened via the examples template. label Jan 17, 2023
@nextjs-bot
Copy link
Collaborator

This issue has been automatically marked as stale due to two years of inactivity. It will be closed in 7 days unless there’s further input. If you believe this issue is still relevant, please leave a comment or provide updated details. Thank you.

@nextjs-bot nextjs-bot added the stale The issue has not seen recent activity. label Jan 16, 2025
@nextjs-bot
Copy link
Collaborator

This issue has been automatically closed due to two years of inactivity. If you’re still experiencing a similar problem or have additional details to share, please open a new issue following our current issue template. Your updated report helps us investigate and address concerns more efficiently. Thank you for your understanding!

@nextjs-bot nextjs-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue was opened via the bug report template. examples Issue was opened via the examples template. stale The issue has not seen recent activity.
Projects
None yet
Development

No branches or pull requests

3 participants