Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numbered arg + path is messed up #5594

Closed
mitchellwrosen opened this issue Feb 28, 2025 · 1 comment · Fixed by #5595
Closed

numbered arg + path is messed up #5594

mitchellwrosen opened this issue Feb 28, 2025 · 1 comment · Fixed by #5595
Assignees
Labels

Comments

@mitchellwrosen
Copy link
Member

I just noticed that a numbered arg that expands to a path seems kind of busted (at least the rendering of it):

Image

In this screenshot, I've run ls fastjson and then view 14. ucm then prints the equivalent command with 14 substituted, which should look like

view fastjson.some

however, it looks like

view RelativePath' (Relative {unrelative = Path {toSeq = fromList [NameSegment {toUnescapedText = "fastjson"}]}}).some

yet we do seem to view the term fine (as if I did type view fastjson.some)

I bisected the bug to this commit; @sellout any ideas?

@mitchellwrosen
Copy link
Member Author

Oh, I think it's because Path has a derived Show instance now: 07fcc66#diff-95fdd8db7d2a6c9350d78132d3614956fa87a627347ec673f60fb2131a75007cL100

This makes lines like this incorrect, since they were rendering paths with show, not Path.toText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant