Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobStats does not handle nulls. #972

Closed
johnynek opened this issue Jul 25, 2014 · 0 comments
Closed

JobStats does not handle nulls. #972

johnynek opened this issue Jul 25, 2014 · 0 comments

Comments

@johnynek
Copy link
Collaborator

Should probably be reworked a bit. Something like:

trait JobStats {
  def totals: Map[StatName, Long]
  def steps: Seq[JobStats]
}

And then we can define a monoid on them and just add them up. Also, I'm not sure exposing the steps is the right thing to do. Should you really be thinking in terms of steps? How do you reason about that? At the application layer, it seems to me you should use different keys to distinguish, not steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant