Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting content annotation using comments or an element #2

Open
thomas-darling opened this issue Dec 5, 2016 · 2 comments

Comments

@thomas-darling
Copy link
Owner

thomas-darling commented Dec 5, 2016

Angular 2 supports annotating content by placing a comment before and after the content that should be exported. We should consider whether adding a similar feature to this plugin would be a good idea.

@thomas-darling
Copy link
Owner Author

See related suggestion in #5.
If we do decide to add a non-attribute way to annotate content, a <translate> element might be a nicer way to go, despite the possible confusion. We would definitely need validation to ensure users don't accidentally add e.g. class names to such an element, as it might be removed during localization...

@thomas-darling thomas-darling changed the title Consider supporting content annotation using comments Consider supporting content annotation using comments or an element Jun 26, 2017
@rs3d
Copy link

rs3d commented Jul 11, 2017

Maybe we can provide an option to keep, replace or delete (default) the element if someone wants to.
It could be a nice feature to make it possible to use a custom element (eg. for web components: https://www.html5rocks.com/en/tutorials/webcomponents/customelements/) and add multiple attributes to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants