Skip to content

Autoscaling cannot be disabled #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nixsticks opened this issue Feb 25, 2019 · 6 comments
Closed

Autoscaling cannot be disabled #83

nixsticks opened this issue Feb 25, 2019 · 6 comments
Labels
upstream Work required on Terraform core or provider

Comments

@nixsticks
Copy link

It appears that users must either specify min_node_count and max_node_count or have them default to 1 and 100; the autoscaling block is always created. Is this by design, or might we in future be able to specify a static node count and disable autoscaling?

@morgante
Copy link
Contributor

morgante commented Mar 4, 2019

Autoscaling is our best practice by default - do you have a use case where specifying max_node_count isn't sufficient?

@nixsticks
Copy link
Author

Hi @morgante! That's my current workaround, yes -- but one use case where it's insufficient is where we want to freeze the current nodepool at zero without additional commands, and prevent it from spinning up new nodes, since max_node_count must be at least 1.

@morgante
Copy link
Contributor

morgante commented Mar 6, 2019

Got it - unfortunately it's tough to have a conditional block in Terraform. If this is a major issue, could you file a provider bug requesting a disabled/enabled flag on the autoscaling block? If there is one, we'd be happy to add it to the module.

@morgante morgante added the upstream Work required on Terraform core or provider label Mar 6, 2019
@aaron-lane
Copy link
Contributor

Hi @nixsticks. Would you like to proceed with an issue on the Google provider or can we close this issue?

@nixsticks
Copy link
Author

Hey @aaron-lane , sorry I didn't follow up on this! We've managed to work around it for now, so no need to file a provider bug / add to the module, I think.

@morgante
Copy link
Contributor

FYI we are now going to look at doing this with Terraform 0.12. See #249.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Work required on Terraform core or provider
Projects
None yet
Development

No branches or pull requests

3 participants