Rewrite ASM module

[Monkeyanator]

The existing ASM module is a near-1:1 wrapper around install_asm which is not ideal. This rewritten module uses the ControlPlaneRevision KRM API to provision the control plane. We still break out and use a provisioner to apply the CPR (due to limitations around the kubernetes_manifest resource) but it's much slimmer than before, and doesn't involve curling down an installation script.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[Monkeyanator]

Addressed comments. CI failing on an issue that doesn't seem related to these changes though, any thoughts here? @bharathkkb

Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        Error: No value for required variable
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":          on variables.tf line 17:
Step #27 - "converge simple-zonal-private-local":          17: variable "project_ids" {
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        The root module input variable "project_ids" is not set, and has no default
Step #27 - "converge simple-zonal-private-local":        value. Use a -var or -var-file command line argument to provide a value for
Step #27 - "converge simple-zonal-private-local":        this variable.
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        Error: No value for required variable
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":          on variables.tf line 33:
Step #27 - "converge simple-zonal-private-local":          33: variable "compute_engine_service_accounts" {
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        The root module input variable "compute_engine_service_accounts" is not set,
Step #27 - "converge simple-zonal-private-local":        and has no default value. Use a -var or -var-file command line argument to
Step #27 - "converge simple-zonal-private-local":        provide a value for this variable.
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        Error: No value for required variable
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":          on variables.tf line 38:
Step #27 - "converge simple-zonal-private-local":          38: variable "registry_project_ids" {
Step #27 - "converge simple-zonal-private-local":        
Step #27 - "converge simple-zonal-private-local":        The root module input variable "registry_project_ids" is not set, and has no
Step #27 - "converge simple-zonal-private-local":        default value. Use a -var or -var-file command line argument to provide a
Step #27 - "converge simple-zonal-private-local":        value for this variable.
Step #27 - "converge simple-zonal-private-local": >>>>>> Running the command `terraform apply -auto-approve -lock=true -lock-timeout=0s -input=false -no-color -parallelism=10 -refresh=true  ` failed due to a non-zero exit code of 1.
Step #27 - "converge simple-zonal-private-local": >>>>>> ------Exception-------
Step #27 - "converge simple-zonal-private-local": >>>>>> Class: Kitchen::ActionFailed
Step #27 - "converge simple-zonal-private-local": >>>>>> Message: 1 actions failed.
Step #27 - "converge simple-zonal-private-local": >>>>>>     Converge failed on instance <simple-zonal-private-local>.  Please see .kitchen/logs/simple-zonal-private-local.log for more details
Step #27 - "converge simple-zonal-private-local": >>>>>> ----------------------
Step #27 - "converge simple-zonal-private-local": >>>>>> Please see .kitchen/logs/kitchen.log for more details
Step #27 - "converge simple-zonal-private-local": >>>>>> Also try running `kitchen diagnose --all` for configuration

[bharathkkb]

@Monkeyanator I noticed it when working on another PR. You can switch to using the registry source for gke-project-asm in test/setup https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/99e8f9b88eff8363eb7a06faff79e460c049ac35/test/setup/main.tf

[bharathkkb]

Opened #1159 since it was affecting a few PRs

[Monkeyanator]

Thanks for looking into it @bharathkkb, made the change from #1159 here but seems like we still run into issues about resources changing (hard to pin down where the step actually fails from the logs). Think the PR with just the fix is failing CI as well

[bharathkkb]

@Monkeyanator seemed like the failure in #1159 was a flake. I have kicked it off again.

Also could we add some kind of upgrade guide for users coming from the old module? Is there a possible upgrade path minimizing disruption?

[Monkeyanator]

@bharathkkb the exposed options and implementation are different enough from the previous implementation where it'll be tough to support a migration path here. Is it possible to document to pin to the old version for this first iteration? Updated the README documenting this.

[bharathkkb]

the exposed options and implementation are different enough from the previous implementation where it'll be tough to support a migration path here.

Makes sense, I dropped a comment above to move that section to the upgrade guide.

[gottfrois]

Super excited that this PR has been merged. Do you think it will solve this issue? #1114

[Monkeyanator]

Super excited that this PR has been merged. Do you think it will solve this issue? #1114

Yes, the segfault probably comes from somewhere in the install_asm script which we completely ditched in the new module

[elebioda]

Why was asm_version removed?