Skip to content

Commit 22896b0

Browse files
authored
fix: handle missing fleet membership and extend asm timeout (#1880)
1 parent 176ad25 commit 22896b0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: modules/asm/scripts/create_cpr.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,4 @@ spec:
5757
channel: "${CHANNEL}"
5858
EOF
5959

60-
kubectl wait -n istio-system --for=condition=Reconciled controlplanerevision/"${REVISION_NAME}" --timeout 10m
60+
kubectl wait -n istio-system --for=condition=Reconciled controlplanerevision/"${REVISION_NAME}" --timeout 20m

Diff for: modules/fleet-membership/main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ locals {
1818
hub_project_id = var.hub_project_id == "" ? var.project_id : var.hub_project_id
1919
gke_hub_membership_name_complete = var.membership_name != "" ? var.membership_name : "${var.project_id}-${var.location}-${var.cluster_name}"
2020
gke_hub_membership_name = trimsuffix(substr(local.gke_hub_membership_name_complete, 0, 63), "-")
21-
gke_hub_membership_location = regex(local.gke_hub_membership_location_re, data.google_container_cluster.primary.fleet[0].membership)[0]
21+
gke_hub_membership_location = try(regex(local.gke_hub_membership_location_re, data.google_container_cluster.primary.fleet[0].membership)[0], null)
2222
gke_hub_membership_location_re = "//gkehub.googleapis.com/projects/[^/]*/locations/([^/]*)/memberships/[^/]*$"
2323
}
2424

0 commit comments

Comments
 (0)