fix: Truncating hub membership ID when greater than 63 character (#1429)

* Truncating Membership ID when greater than 63 character

* Correcting Linting

* Modifying If Logic and Adding Trim Suffix

Co-authored-by: Akshay Bathija <akshaybathija@google.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>

Author: 3 people

Diff for: modules/fleet-membership/main.tf

@@ -15,8 +15,9 @@
  */
 
 locals {
-  hub_project_id          = var.hub_project_id == "" ? var.project_id : var.hub_project_id
-  gke_hub_membership_name = var.membership_name != "" ? var.membership_name : "${var.project_id}-${var.location}-${var.cluster_name}"
+  hub_project_id                   = var.hub_project_id == "" ? var.project_id : var.hub_project_id
+  gke_hub_membership_name_complete = var.membership_name != "" ? var.membership_name : "${var.project_id}-${var.location}-${var.cluster_name}"
+  gke_hub_membership_name          = trimsuffix(substr(local.gke_hub_membership_name_complete, 0, 63), "-")
 }
 
 # Retrieve GKE cluster info