Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indication for choose-file mode #2263

Closed
2 of 3 tasks
Tyarel8 opened this issue Jan 29, 2025 · 2 comments · Fixed by #2392
Closed
2 of 3 tasks

Visual indication for choose-file mode #2263

Tyarel8 opened this issue Jan 29, 2025 · 2 comments · Fixed by #2392
Labels
feature New feature request

Comments

@Tyarel8
Copy link
Contributor

Tyarel8 commented Jan 29, 2025

yazi --debug output

.

Please describe the problem you're trying to solve

When using the --chooser-file option (#69), there is no visual indication anywhere in the UI that this mode is active. While not a critical feature or anything, I think it is good UX to have an indication that this mode is active since it completely changes how the open command works and you wouldn't know it from inside yazi.

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

I don't have anything specific in mind, it could be a title at the top, an icon in a corner somewhere, having the theme change some color when this mode is active, etc.

Additional context

No response

Checklist

  • I have searched the existing issues/discussions
  • The latest nightly build doesn't already have this feature
@Tyarel8 Tyarel8 added the feature New feature request label Jan 29, 2025
@sxyazi
Copy link
Owner

sxyazi commented Jan 29, 2025

I'm not sure where to display it. Instead of directly adding it, I'd prefer to provide an API to implement it, so users can just paste a few lines of Lua code into their init.lua when they need it, kind of like the tips in there (https://yazi-rs.github.io/docs/tips#username-hostname-in-header and https://yazi-rs.github.io/docs/tips#user-group-in-status).

Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants