Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on a custom engine fork #18

Closed
stechyo opened this issue Jan 6, 2024 · 9 comments
Closed

Remove dependency on a custom engine fork #18

stechyo opened this issue Jan 6, 2024 · 9 comments
Labels
tracker For tracking an external issue

Comments

@stechyo
Copy link
Owner

stechyo commented Jan 6, 2024

Obviously I'd like to not make every user rely on downloading some guy's fork of Godot to use this extension. However, this is not feasible right now. This issue is blocked by:

godotengine/godot-proposals#8609
godotengine/godot#86539 (or another pull request that does this in a better way)

@stechyo stechyo added the enhancement New improvement to an existing feature label Jan 6, 2024
@stechyo stechyo added tracker For tracking an external issue and removed enhancement New improvement to an existing feature labels Jan 13, 2024
@stechyo stechyo changed the title Tracker: remove dependency on a custom engine fork Remove dependency on a custom engine fork Jan 13, 2024
@fire
Copy link

fire commented Feb 22, 2024

Is this still valid?

@stechyo
Copy link
Owner Author

stechyo commented Feb 22, 2024

Yeah.

@octanejohn
Copy link

octanejohn commented Oct 24, 2024

this can close i think, is going to be in godot 4.4

@fire
Copy link

fire commented Oct 24, 2024

As far as I can tell all the godot-steam-audio documentation says it requires a godot fork.

stechyo/godot@231d764

@octanejohn
Copy link

this pr was merged godotengine/godot#86539

@fire
Copy link

fire commented Oct 24, 2024

Cheers

@stechyo
Copy link
Owner Author

stechyo commented Oct 25, 2024

Yeah! Closing this.

@stechyo stechyo closed this as completed Oct 25, 2024
@TheIndiv
Copy link
Contributor

TheIndiv commented Dec 8, 2024

Wait, so a custom fork is no longer required?

@stechyo
Copy link
Owner Author

stechyo commented Dec 8, 2024

It is not required provided you get the release on the PR, and you are using Godot 4.4. When there is a stable release for 4.4 I’ll merge the PR and release a new version of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracker For tracking an external issue
Projects
None yet
Development

No branches or pull requests

4 participants