Skip to content

Raster extension #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 1, 2021
Merged

Conversation

emmanuelmathot
Copy link
Contributor

@emmanuelmathot emmanuelmathot commented May 26, 2021

Description:

Implements the raster extension

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@emmanuelmathot emmanuelmathot marked this pull request as ready for review May 27, 2021 06:21
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #364 (be2e41c) into main (e90f809) will increase coverage by 0.02%.
The diff coverage is 90.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.02%     
==========================================
  Files          37       38       +1     
  Lines        4677     4953     +276     
==========================================
+ Hits         4199     4448     +249     
- Misses        478      505      +27     
Impacted Files Coverage Δ
pystac/extensions/raster.py 90.21% <90.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90f809...be2e41c. Read the comment docs.

@lossyrob lossyrob added this to the 1.0.0 milestone May 27, 2021
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @emmanuelmathot. I added some suggested changes to bring the docstrings in line with some changes from recent PRs.

We should also add the classes from pystac.extensions.raster into the API docs by adding them to docs/api.rst.

emmanuelmathot and others added 12 commits May 31, 2021 10:47
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
Co-authored-by: Jon Duckworth <duckontheweb@gmail.com>
@emmanuelmathot
Copy link
Contributor Author

Thank you @duckontheweb for the review!

@duckontheweb duckontheweb self-requested a review May 31, 2021 14:39
emmanuelmathot added a commit to stac-extensions/raster that referenced this pull request May 31, 2021
@duckontheweb duckontheweb self-requested a review May 31, 2021 23:57
@duckontheweb duckontheweb merged commit 6f4ca38 into stac-utils:main Jun 1, 2021
@duckontheweb duckontheweb modified the milestones: 1.0.0, 1.0.0-rc.1 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants