Skip to content

Tests and documentation for Datacube extension #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lossyrob opened this issue May 3, 2021 · 3 comments · Fixed by #1143
Closed

Tests and documentation for Datacube extension #324

lossyrob opened this issue May 3, 2021 · 3 comments · Fixed by #1143
Assignees
Milestone

Comments

@lossyrob
Copy link
Member

lossyrob commented May 3, 2021

As part of #309 the Datacube extension was implemented (closing #30). There's testing and documentation left to do on this extension that should go in before the 1.0 release.

@duckontheweb
Copy link
Contributor

Moving this out to 1.3.0 release since I won't have time to work on it for 1.2.0

@duckontheweb
Copy link
Contributor

Moving this to the next release.

@duckontheweb duckontheweb modified the milestones: 1.3.0, 1.4.0 Jan 18, 2022
@duckontheweb duckontheweb modified the milestones: 1.4.0, 1.5.0 Feb 23, 2022
@guidorice
Copy link
Contributor

guidorice commented Mar 18, 2022

I am in process of adding more unit tests to pystac/extensions/datacube.py, but it occurs to me that Dimension takes a dict in it's constructor, so also should have create and apply, same as in #576 .

I think it might turn into a bit of a refactor of some of the datacube classes, because from_dict here seems awkward being defined in the Abstract Base Class.

Instead, from_dict, create and apply could be implemented by the concrete subclasses. Let me know if any opinions pro or con- I am not experienced using the ABC package.

cc @duckontheweb

@gadomski gadomski modified the milestones: 1.7, 1.8 Jan 31, 2023
@jsignell jsignell self-assigned this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants