Restore default max_items behavior (#273)

* Restore default max_items behavior

xref #237 (comment)

Doesn't close that issue, which also deals with the replacement for the
deprecated methods. This just reverts the change to the default
`max_items` to return all matching items by default.

* vcr

* alias

Author: Tom Augspurger

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 
 - Fix type annotation of `Client._stac_io` and avoid implicit re-exports in `pystac_client.__init__.py` [#249](https://github.com/stac-utils/pystac-client/pull/249)
+- Restored the previous behavior of ``Client.search()`` to return an unlimited number of items by default. [#273](https://github.com/stac-utils/pystac-client/pull/273)
 - Added `ItemSearch.item_collection()` as a replacement for the deprecated `ItemSearch.get_all_items()` [#237](https://github.com/stac-utils/pystac-client/issues/237)
 
 ## [v0.4.0] - 2022-06-08

README.md

@@ -11,10 +11,12 @@ A Python client for working with [STAC](https://stacspec.org/) Catalogs and APIs
 
 ## Table of Contents
 
+- [Table of Contents](#table-of-contents)
 - [Installation](#installation)
 - [Documentation](#documentation)
 - [Development](#development)
-   - [Pull Requests](#pull-requests)
+  - [Pull Requests](#pull-requests)
+  - [Benchmark](#benchmark)
 
 ## Installation
 
@@ -70,7 +72,7 @@ $ git add <new files here>
 $ git commit -a -m 'new test episodes'
 ```
 
-To update pystac-client to use future versions of STAC API, the existing recorded API responsees
+To update pystac-client to use future versions of STAC API, the existing recorded API responses
 should be "re-recorded":
 
 ```shell

pystac_client/item_search.py

@@ -76,7 +76,10 @@
 
 OPS = list(OP_MAP.keys())
 
-DEFAULT_LIMIT_AND_MAX_ITEMS = 100
+# Previously named DEFAULT_LIMIT_AND_MAX_ITEMS
+# aliased for backwards compat
+# https://github.com/stac-utils/pystac-client/pull/273
+DEFAUL_LIMIT = DEFAULT_LIMIT_AND_MAX_ITEMS = 100
 
 
 # from https://gist.github.com/angstwad/bf22d1822c38a92ec0a9#gistcomment-2622319
@@ -140,12 +143,12 @@ class ItemSearch:
             the response, it will automatically retry with
             ``"GET"`` for all subsequent requests.
         max_items : The maximum number of items to return from the search, even
-            if there are more matching results. This client to limit the
+            if there are more matching results. This allows the client to limit the
             total number of Items returned from the :meth:`items`,
             :meth:`item_collections`, and :meth:`items_as_dicts methods`. The client
             will continue to request pages of items until the number of max items is
-            reached. This parameter defaults to 100. Setting this to ``None`` will
-            allow iteration over a possibly very large number of results.
+            reached. By default (``max_items=None``) all items matching the query
+            will be returned.
         stac_io: An instance of StacIO for retrieving results. Normally comes
             from the Client that returns this ItemSearch client: An instance of a
             root Client used to set the root on resulting Items.
@@ -217,7 +220,7 @@ def __init__(
         url: str,
         *,
         method: Optional[str] = "POST",
-        max_items: Optional[int] = DEFAULT_LIMIT_AND_MAX_ITEMS,
+        max_items: Optional[int] = None,
         stac_io: Optional[StacApiIO] = None,
         client: Optional["_client.Client"] = None,
         limit: Optional[int] = DEFAULT_LIMIT_AND_MAX_ITEMS,