-
Notifications
You must be signed in to change notification settings - Fork 41.1k
spring-boot-dependencies contains unwanted dependency management #42522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not just Log4j2's bom that is problematic. A prototype for #42523 has found the following problems in 3.2.x:
|
This comment has been minimized.
This comment has been minimized.
To fix this, we'd have to stop using the boms from various projects. Currently, the worst offenders are Log4j and JAX-B. Unfortunately, moving away from using a bom has the downside that it makes it harder for users to upgrade to a new version of a library when that new version introduces a new module. They can no longer simply override the version property, instead they also have to declare dependency management for the new module. 3.5.x is the last minor in the 3.x line and will be an "LTS" release which increases the likelihood that users will want to upgrade to a new minor of a managed dependency during its lifetime. As such, I think it would be a mistake to move away from using the Log4j and JAX-B boms in 3.5.x. We can look at this in 4.0.x instead which will have a short support period as it will be followed by 4.1.x, 4.2.x, etc. |
It's being inherited from
log4j-bom
. In 3.2.x (Log4j 2.21), it's contributing management for the following dependencies:biz.aQute.bnd:biz.aQute.bnd.annotation:6.4.1
com.github.spotbugs:spotbugs-annotations:4.7.3
org.osgi:osgi.annotation:8.1.0
org.osgi:org.osgi.annotation.bundle:2.0.0
org.apache.maven.plugin-tools:maven-plugin-annotations:3.9.0
In 3.3.x (Log4j 2.23), it's the following:
biz.aQute.bnd:biz.aQute.bnd.annotation:7.0.0
com.github.spotbugs:spotbugs-annotations:4.8.3
org.jspecify:jspecify:0.3.0
org.osgi:osgi.annotation:8.1.0
org.osgi:org.osgi.annotation.bundle:2.0.0
org.osgi:org.osgi.annotation.versioning:1.1.2
org.apache.maven.plugin-tools:maven-plugin-annotations:3.10.2
In 3.4.x (Log4j 2.24), it's the following:
biz.aQute.bnd:biz.aQute.bnd.annotation:7.0.0
com.github.spotbugs:spotbugs-annotations:4.8.6
org.jspecify:jspecify:1.0.0
org.osgi:osgi.annotation:8.1.0
org.osgi:org.osgi.annotation.bundle:2.0.0
org.osgi:org.osgi.annotation.versioning:1.1.2
org.apache.maven.plugin-tools:maven-plugin-annotations:3.13.1
I've opened apache/logging-log4j2#3066 to see if the bom can be improved to remove this unwanted dependency management. In the meantime, we may want to move away from using it.
The text was updated successfully, but these errors were encountered: