Skip to content

Commit d8816d8

Browse files
committed
Removing deprecated FirefoxProfile.setProxyPreferences method.
1 parent c259e57 commit d8816d8

File tree

1 file changed

+4
-52
lines changed

1 file changed

+4
-52
lines changed

Diff for: java/client/src/org/openqa/selenium/firefox/FirefoxProfile.java

+4-52
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616

1717
package org.openqa.selenium.firefox;
1818

19+
import static org.openqa.selenium.firefox.FirefoxDriver.ACCEPT_UNTRUSTED_CERTIFICATES;
20+
import static org.openqa.selenium.firefox.FirefoxDriver.ASSUME_UNTRUSTED_ISSUER;
21+
import static org.openqa.selenium.firefox.FirefoxDriver.DEFAULT_ENABLE_NATIVE_EVENTS;
22+
1923
import com.google.common.annotations.VisibleForTesting;
2024
import com.google.common.collect.Maps;
2125
import com.google.common.io.Resources;
2226

2327
import org.openqa.selenium.Beta;
24-
import org.openqa.selenium.Proxy;
25-
import org.openqa.selenium.Proxy.ProxyType;
2628
import org.openqa.selenium.WebDriverException;
2729
import org.openqa.selenium.firefox.internal.ClasspathExtension;
2830
import org.openqa.selenium.firefox.internal.Extension;
@@ -41,10 +43,6 @@
4143
import java.net.URL;
4244
import java.util.Map;
4345

44-
import static org.openqa.selenium.firefox.FirefoxDriver.ACCEPT_UNTRUSTED_CERTIFICATES;
45-
import static org.openqa.selenium.firefox.FirefoxDriver.ASSUME_UNTRUSTED_ISSUER;
46-
import static org.openqa.selenium.firefox.FirefoxDriver.DEFAULT_ENABLE_NATIVE_EVENTS;
47-
4846

4947
public class FirefoxProfile {
5048
public static final String PORT_PREFERENCE = "webdriver_firefox_port";
@@ -232,52 +230,6 @@ public void setPreference(String key, int value) {
232230
additionalPrefs.setPreference(key, value);
233231
}
234232

235-
/**
236-
* Set proxy preferences for this profile.
237-
*
238-
* @param proxy The proxy preferences.
239-
* @return The profile, for further settings.
240-
* @deprecated This is now handled by the driver itself.
241-
*/
242-
@Deprecated
243-
public FirefoxProfile setProxyPreferences(Proxy proxy) {
244-
if (proxy.getProxyType() == ProxyType.UNSPECIFIED) {
245-
return this;
246-
}
247-
setPreference("network.proxy.type", proxy.getProxyType().ordinal());
248-
249-
switch (proxy.getProxyType()) {
250-
case MANUAL:// By default, assume we're proxying the lot
251-
setPreference("network.proxy.no_proxies_on", "");
252-
253-
setManualProxyPreference("ftp", proxy.getFtpProxy());
254-
setManualProxyPreference("http", proxy.getHttpProxy());
255-
setManualProxyPreference("ssl", proxy.getSslProxy());
256-
setManualProxyPreference("socks", proxy.getSocksProxy());
257-
if (proxy.getNoProxy() != null) {
258-
setPreference("network.proxy.no_proxies_on", proxy.getNoProxy());
259-
}
260-
261-
break;
262-
case PAC:
263-
setPreference("network.proxy.autoconfig_url", proxy.getProxyAutoconfigUrl());
264-
break;
265-
}
266-
return this;
267-
}
268-
269-
private void setManualProxyPreference(String key, String settingString) {
270-
if (settingString == null) {
271-
return;
272-
}
273-
String[] hostPort = settingString.split(":");
274-
setPreference("network.proxy." + key, hostPort[0]);
275-
if (hostPort.length > 1) {
276-
setPreference("network.proxy." + key + "_port", Integer.parseInt(hostPort[1]));
277-
}
278-
}
279-
280-
281233
protected Preferences getAdditionalPreferences() {
282234
return additionalPrefs;
283235
}

0 commit comments

Comments
 (0)