Skip to content

Typo in CTGAN code #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ori-katz100 opened this issue Jun 27, 2021 · 2 comments · Fixed by #160
Closed

Typo in CTGAN code #158

ori-katz100 opened this issue Jun 27, 2021 · 2 comments · Fixed by #160
Labels
bug Something isn't working
Milestone
0.5.0

Comments

@ori-katz100
Copy link

ori-katz100 commented Jun 27, 2021 •
edited by pvk-developer
Loading

Hello,
I think that you have a mistake in the file ctgan.py line 363: you wrote fake_cat = fake but it should be fake_cat = fakeact.

Best,
Ori
@ori-katz100 ori-katz100 added the bug Something isn't working label Jun 27, 2021
@fealho fealho mentioned this issue Jul 8, 2021
Merged
@fealho
Copy link
Member

fealho commented Jul 14, 2021

Hi @ori-katz100, that's a great catch! It actually improves performance quite a bit, so thanks a lot!

@Baukebrenninkmeijer
Copy link
Contributor

Oh wow, this is a super important difference :')

@pvk-developer pvk-developer added this to the 0.5.0 milestone Nov 18, 2021
@pvk-developer pvk-developer changed the title A small error in your code Typo in CTGAN code Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Apply the activation function to fake before passing to fake_cat sdv-dev/CTGAN
4 participants
@Baukebrenninkmeijer @fealho @pvk-developer @ori-katz100