Fix caching problem when computing implicit scopes

odersky · odersky · commit 88a18e5030b7 · 2016-05-03T22:03:35.000+02:00
Caches were set when information was not complete yet. Problem was
exhibited by missing some `eqName` implicits when adding safe equality
for Name.
diff --git a/src/dotty/tools/dotc/typer/Implicits.scala b/src/dotty/tools/dotc/typer/Implicits.scala
@@ -361,7 +361,7 @@ trait ImplicitRunInfo { self: RunInfo =>
         computeIScope(cacheResult = false)
       else implicitScopeCache get tp match {
         case Some(is) => is
-        case None => computeIScope(cacheResult = true)
+        case None => computeIScope(cacheResult = seen.isEmpty)
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ trait ImplicitRunInfo { self: RunInfo =>`
`361`	`361`	`computeIScope(cacheResult = false)`
`362`	`362`	`else implicitScopeCache get tp match {`
`363`	`363`	`case Some(is) => is`
`364`		`- case None => computeIScope(cacheResult = true)`
	`364`	`+ case None => computeIScope(cacheResult = seen.isEmpty)`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`