Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] modules/ipset.py has a malformed "cmd.extend" statement for ipset_family #62255

Closed
Monual opened this issue Jun 30, 2022 · 2 comments
Closed
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@Monual
Copy link

Monual commented Jun 30, 2022

Description
Trying to add a family to an existing ipset throws an exception from modules/ipset.py. Looking at the file, it is easy to see that the cmd.extend function on line 332 is written incorrectly.

This bug was introduced in 3004-2

Additional context
Line 332 should be changed from:

    `cmd.extend(["family", cmd, ipset_family])`

to:

    `cmd.extend(["family", ipset_family])`
@Monual Monual added Bug broken, incorrect, or confusing behavior needs-triage labels Jun 30, 2022
@welcome
Copy link

welcome bot commented Jun 30, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@Monual
Copy link
Author

Monual commented Jun 30, 2022

Looks like this is a duplicate of #61620. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant