Call os._exit() instead of sys.exit() on forked processes.

s0undt3ch · Megan Wilhite · commit 4ec04292e5da · 2023-01-03T13:17:46.000-07:00
This avoids some tracebacks while python is shutting down.

Signed-off-by: Pedro Algarvio &lt;palgarvio@vmware.com&gt;
diff --git a/salt/utils/process.py b/salt/utils/process.py
@@ -1090,7 +1090,8 @@ def _handle_signals(self, signum, sigframe):
                     self.pid,
                     os.getpid(),
                 )
-        sys.exit(salt.defaults.exitcodes.EX_OK)
+        # It's OK to call os._exit instead of sys.exit on forked processed
+        os._exit(salt.defaults.exitcodes.EX_OK)
 
     def start(self):
         with default_signals(signal.SIGINT, signal.SIGTERM):

Original file line number	Diff line number	Diff line change
`@@ -1090,7 +1090,8 @@ def _handle_signals(self, signum, sigframe):`
`1090`	`1090`	`self.pid,`
`1091`	`1091`	`os.getpid(),`
`1092`	`1092`	`)`
`1093`		`- sys.exit(salt.defaults.exitcodes.EX_OK)`
	`1093`	`+ # It's OK to call os._exit instead of sys.exit on forked processed`
	`1094`	`+ os._exit(salt.defaults.exitcodes.EX_OK)`
`1094`	`1095`
`1095`	`1096`	`def start(self):`
`1096`	`1097`	`with default_signals(signal.SIGINT, signal.SIGTERM):`