Skip to content

Commit 41881aa

Browse files
author
Tom Maher
committed
remove vagrant port override, because $INTEGRATION_PORT
1 parent d2ba5e6 commit 41881aa

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

Diff for: test/integration/test_bind.rb

-6
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def test_bind_tls_with_cafile
4444

4545
def test_bind_tls_with_bad_hostname_verify_none_no_ca_passes
4646
@ldap.host = '127.0.0.1'
47-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
4847
@ldap.encryption(
4948
method: :start_tls,
5049
tls_options: { verify_mode: OpenSSL::SSL::VERIFY_NONE },
@@ -55,7 +54,6 @@ def test_bind_tls_with_bad_hostname_verify_none_no_ca_passes
5554

5655
def test_bind_tls_with_bad_hostname_verify_none_no_ca_opt_merge_passes
5756
@ldap.host = '127.0.0.1'
58-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
5957
@ldap.encryption(
6058
method: :start_tls,
6159
tls_options: TLS_OPTS.merge(verify_mode: OpenSSL::SSL::VERIFY_NONE),
@@ -66,7 +64,6 @@ def test_bind_tls_with_bad_hostname_verify_none_no_ca_opt_merge_passes
6664

6765
def test_bind_tls_with_bad_hostname_verify_peer_ca_fails
6866
@ldap.host = '127.0.0.1'
69-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
7067
@ldap.encryption(
7168
method: :start_tls,
7269
tls_options: { verify_mode: OpenSSL::SSL::VERIFY_PEER,
@@ -84,7 +81,6 @@ def test_bind_tls_with_bad_hostname_verify_peer_ca_fails
8481

8582
def test_bind_tls_with_bad_hostname_ca_default_opt_merge_fails
8683
@ldap.host = '127.0.0.1'
87-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
8884
@ldap.encryption(
8985
method: :start_tls,
9086
tls_options: TLS_OPTS.merge(ca_file: CA_FILE),
@@ -101,7 +97,6 @@ def test_bind_tls_with_bad_hostname_ca_default_opt_merge_fails
10197

10298
def test_bind_tls_with_valid_hostname_default_opts_passes
10399
@ldap.host = 'localhost'
104-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
105100
@ldap.encryption(
106101
method: :start_tls,
107102
tls_options: TLS_OPTS.merge(verify_mode: OpenSSL::SSL::VERIFY_PEER,
@@ -113,7 +108,6 @@ def test_bind_tls_with_valid_hostname_default_opts_passes
113108

114109
def test_bind_tls_with_valid_hostname_just_verify_peer_ca_passes
115110
@ldap.host = 'localhost'
116-
@ldap.port = 9389 unless ENV['TRAVIS'] == 'true'
117111
@ldap.encryption(
118112
method: :start_tls,
119113
tls_options: { verify_mode: OpenSSL::SSL::VERIFY_PEER,

Diff for: test/support/vm/openldap/README.md

+3
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ $ ip=$(vagrant ssh -- "ifconfig eth1 | grep -o -E '[0-9]+\.[0-9]+\.[0-9]+\.[0-9]
3434
# change back to root project directory
3535
$ cd ../../../..
3636

37+
# set the TCP port for testing
38+
$ export INTEGRATION_PORT=9389
39+
3740
# run all tests, including integration tests
3841
$ time INTEGRATION=openldap INTEGRATION_HOST=$ip bundle exec rake
3942

0 commit comments

Comments
 (0)