Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinstall hook #1805

Open
mumoshu opened this issue Apr 24, 2021 · 7 comments
Open

postinstall hook #1805

mumoshu opened this issue Apr 24, 2021 · 7 comments

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Apr 24, 2021

Just wanted to have a dedicated issue for this.

Would anyone use it if Helmfile added a new postinstall hook?

It has been originally proposed by @cdunford in #1291. Althought I thought it was great, I had overwhelmed by all the works I had in Helmfile and forgot to discuss/implementing it.

@sandep121
Copy link

It will be nice to have postinstall in helmfile. I have a use case where I have to add a label to the namespace after the helm chart is installed, postinstall will come in handy in this case.

@anovikov-el
Copy link

anovikov-el commented Jun 14, 2021

It would be good for Helmfile to support both preinstall and postinstall hook. Our use case is when we need to copy a K8S secret from one namespace/release to another namespace/release (in k8s you cannot share secrets across the namespaces), so it should be executed before installation of the second one.

@anovikov-el
Copy link

any update here?

@mitom
Copy link

mitom commented Aug 2, 2021

Another use-case for pre-install is that some managed k8s providers (e.g. EKS) provision clusters with some things pre-configured, like the default storage class. When we want to deploy a chart that provides other options and want to configure the default, we have to somehow unset the original default first (or in some cases, to just delete the existing one so we can move it into helm).

@philicious
Copy link

I'd like to also express interested in preinstall hook in particular and also all helm hooks in general.

Use-Case: Similar to deleting default storage-class, I want/need to delete the default AWS-CNI before I can sync the custom configured one

@rabbagliettiandrea
Copy link

+1, it would be super useful!

@tomislater
Copy link

Yeah; in our case it also would be great. For example we install karpenter via helm chart, but for NodePool objects we have just yamls:

      - events: ["postsync"]
        showlogs: true
        command: "kubectl"
        args:
          - apply
          - --namespace
          - '{{`{{ .Release.Namespace }}`}}'
          - -f
          - values/{{ .Environment.Name }}/karpenter-nodes/*.yaml

Now we need to use postsync to install them and helmfile sync, because helmfile apply does not trigger this for some reason 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants