Skip to content

Commit 3c1c478

Browse files
authored
chore: more detail log info when key_binder/bindings parsing errors happen (#922)
1 parent cdab893 commit 3c1c478

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/rime/gear/key_binder.cc

+11-4
Original file line numberDiff line numberDiff line change
@@ -178,20 +178,25 @@ void KeyBindings::LoadBindings(const an<ConfigList>& bindings) {
178178
}
179179
KeyEvent key;
180180
if (!key.Parse(pattern->str())) {
181-
LOG(WARNING) << "invalid key binding #" << i << ".";
181+
LOG(WARNING) << "invalid key binding #" << i
182+
<< ", with invalid accept pattern: " << pattern->str()
183+
<< ".";
182184
continue;
183185
}
184186
if (auto target = map->GetValue("send")) {
185187
KeyEvent key;
186188
if (key.Parse(target->str())) {
187189
binding.target.push_back(std::move(key));
188190
} else {
189-
LOG(WARNING) << "invalid key binding #" << i << ".";
191+
LOG(WARNING) << "invalid key binding #" << i
192+
<< ", with invalid send pattern: " << target->str() << ".";
190193
continue;
191194
}
192195
} else if (auto target = map->GetValue("send_sequence")) {
193196
if (!binding.target.Parse(target->str())) {
194-
LOG(WARNING) << "invalid key sequence #" << i << ".";
197+
LOG(WARNING) << "invalid key sequence #" << i
198+
<< ", with invalid send_sequence pattern: "
199+
<< target->str() << ".";
195200
continue;
196201
}
197202
} else if (auto option = map->GetValue("toggle")) {
@@ -211,7 +216,9 @@ void KeyBindings::LoadBindings(const an<ConfigList>& bindings) {
211216
select_schema(engine, schema->str());
212217
};
213218
} else {
214-
LOG(WARNING) << "invalid key binding #" << i << ".";
219+
LOG(WARNING) << "invalid key binding #" << i
220+
<< ", accept: " << pattern->str()
221+
<< ", when: " << whence->str() << ".";
215222
continue;
216223
}
217224
Bind(key, binding);

0 commit comments

Comments
 (0)