Skip to content

Commit f7f1955

Browse files
committed
Drop deprecated ExtLibeventLoop and ExtLibevLoop (PHP 5 only)
1 parent e86b09e commit f7f1955

9 files changed

+3
-679
lines changed

.github/workflows/ci.yml

+1-29
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343

4444
PHPUnit-Unstable:
4545
name: PHPUnit (Unstable PHP ${{ matrix.php }})
46-
runs-on: ubuntu-20.04
46+
runs-on: ubuntu-22.04
4747
continue-on-error: true
4848
strategy:
4949
matrix:
@@ -57,10 +57,6 @@ jobs:
5757
- 7.2
5858
- 7.1
5959
- 7.0
60-
- 5.6
61-
- 5.5
62-
- 5.4
63-
- 5.3
6460
steps:
6561
- uses: actions/checkout@v4
6662
- uses: shivammathur/setup-php@v2
@@ -74,30 +70,6 @@ jobs:
7470
sudo apt-get update -q && sudo apt-get install libuv1-dev
7571
echo "yes" | sudo pecl install ${{ matrix.php >= 8.0 && 'uv-0.3.0' || 'uv-0.2.4' }}
7672
php -m | grep -q uv || echo "extension=uv.so" >> "$(php -r 'echo php_ini_loaded_file();')"
77-
if: ${{ matrix.php >= 7.0 }}
78-
- name: Install legacy ext-libevent on PHP < 7.0
79-
run: |
80-
sudo apt-get update && sudo apt-get install libevent-dev
81-
curl http://pecl.php.net/get/libevent-0.1.0.tgz | tar -xz
82-
pushd libevent-0.1.0
83-
phpize
84-
./configure
85-
make
86-
sudo make install
87-
popd
88-
echo "extension=libevent.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')"
89-
if: ${{ matrix.php < 7.0 }}
90-
- name: Install legacy ext-libev on PHP < 7.0
91-
run: |
92-
git clone --recursive https://github.com/m4rw3r/php-libev
93-
pushd php-libev
94-
phpize
95-
./configure --with-libev
96-
make
97-
sudo make install
98-
popd
99-
echo "extension=libev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')"
100-
if: ${{ matrix.php < 7.0 }}
10173
- run: composer install
10274
- run: vendor/bin/phpunit --coverage-text
10375
if: ${{ matrix.php >= 7.3 }}

README.md

-42
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ single [`run()`](#run) call that is controlled by the user.
3333
* [ExtEventLoop](#exteventloop)
3434
* [ExtEvLoop](#extevloop)
3535
* [ExtUvLoop](#extuvloop)
36-
* [~~ExtLibeventLoop~~](#extlibeventloop)
37-
* [~~ExtLibevLoop~~](#extlibevloop)
3836
* [LoopInterface](#loopinterface)
3937
* [run()](#run)
4038
* [stop()](#stop)
@@ -429,46 +427,6 @@ that provides an interface to `libuv` library.
429427

430428
This loop is known to work with PHP 7+.
431429

432-
#### ~~ExtLibeventLoop~~
433-
434-
> Deprecated since v1.2.0, use [`ExtEventLoop`](#exteventloop) instead.
435-
436-
An `ext-libevent` based event loop.
437-
438-
This uses the [`libevent` PECL extension](https://pecl.php.net/package/libevent),
439-
that provides an interface to `libevent` library.
440-
`libevent` itself supports a number of system-specific backends (epoll, kqueue).
441-
442-
This event loop does only work with PHP 5.
443-
An [unofficial update](https://github.com/php/pecl-event-libevent/pull/2) for
444-
PHP 7 does exist, but it is known to cause regular crashes due to `SEGFAULT`s.
445-
To reiterate: Using this event loop on PHP 7 is not recommended.
446-
Accordingly, neither the [`Loop` class](#loop) nor the deprecated
447-
[`Factory` class](#factory) will try to use this event loop on PHP 7.
448-
449-
This event loop is known to trigger a readable listener only if
450-
the stream *becomes* readable (edge-triggered) and may not trigger if the
451-
stream has already been readable from the beginning.
452-
This also implies that a stream may not be recognized as readable when data
453-
is still left in PHP's internal stream buffers.
454-
As such, it's recommended to use `stream_set_read_buffer($stream, 0);`
455-
to disable PHP's internal read buffer in this case.
456-
See also [`addReadStream()`](#addreadstream) for more details.
457-
458-
#### ~~ExtLibevLoop~~
459-
460-
> Deprecated since v1.2.0, use [`ExtEvLoop`](#extevloop) instead.
461-
462-
An `ext-libev` based event loop.
463-
464-
This uses an [unofficial `libev` extension](https://github.com/m4rw3r/php-libev),
465-
that provides an interface to `libev` library.
466-
`libev` itself supports a number of system-specific backends (epoll, kqueue).
467-
468-
This loop does only work with PHP 5.
469-
An update for PHP 7 is [unlikely](https://github.com/m4rw3r/php-libev/issues/8)
470-
to happen any time soon.
471-
472430
### LoopInterface
473431

474432
#### run()

src/ExtLibevLoop.php

-201
This file was deleted.

0 commit comments

Comments
 (0)