Skip to content

Commit 475224e

Browse files
committed
put android toolbar titles in the strings file
1 parent 12c1a57 commit 475224e

File tree

3 files changed

+36
-33
lines changed

3 files changed

+36
-33
lines changed

mode/languages/mode.properties

+12
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,22 @@
1111
# | File | Edit | Sketch | Android | Tools | Help |
1212
# | File |
1313

14+
menu.sketch.stop = Stop
15+
menu.file.new = New
16+
menu.file.open = Open
17+
menu.file.save = Save
18+
1419
menu.file.export_signed_package = Export Signed Package
1520
menu.file.export_signed_bundle = Export Signed Bundle
1621
menu.file.export_android_project = Export Android Project
1722

23+
24+
# | File | Edit | Sketch | Android | Tools | Help |
25+
# | Sketch |
26+
27+
menu.sketch.run_on_device = Run on Device
28+
menu.sketch.run_in_emulator = Run in Emulator
29+
1830
# | File | Edit | Sketch | Android | Tools | Help |
1931
# | Android |
2032

mode/src/processing/mode/android/AndroidEditor.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -123,16 +123,16 @@ public boolean handleSaveAs() {
123123

124124

125125
public JMenu buildFileMenu() {
126-
String exportPackageTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_PACKAGE, true);
127-
JMenuItem exportPackage = Toolkit.newJMenuItem(exportPackageTitle, 'K');
126+
String exportPackageTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_PACKAGE);
127+
JMenuItem exportPackage = Toolkit.newJMenuItemExt(exportPackageTitle);
128128
exportPackage.addActionListener(new ActionListener() {
129129
public void actionPerformed(ActionEvent e) {
130130
handleExportPackage();
131131
}
132132
});
133133

134134

135-
String exportBundleTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_BUNDLE, false);
135+
String exportBundleTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_BUNDLE);
136136
JMenuItem exportBundle = Toolkit.newJMenuItem(exportBundleTitle, 'B');
137137
exportBundle.addActionListener(new ActionListener() {
138138
public void actionPerformed(ActionEvent e) {
@@ -141,7 +141,7 @@ public void actionPerformed(ActionEvent e) {
141141
});
142142

143143

144-
String exportProjectTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_PROJECT, true);
144+
String exportProjectTitle = AndroidToolbar.getTitle(AndroidToolbar.EXPORT_PROJECT);
145145
JMenuItem exportProject = Toolkit.newJMenuItemShift(exportProjectTitle, 'X');
146146
exportProject.addActionListener(new ActionListener() {
147147
public void actionPerformed(ActionEvent e) {
@@ -154,21 +154,21 @@ public void actionPerformed(ActionEvent e) {
154154

155155

156156
public JMenu buildSketchMenu() {
157-
JMenuItem runItem = Toolkit.newJMenuItem(AndroidToolbar.getTitle(AndroidToolbar.RUN, false), 'D');
157+
JMenuItem runItem = Toolkit.newJMenuItem(AndroidToolbar.getTitle(AndroidToolbar.RUN_ON_DEVICE), 'D');
158158
runItem.addActionListener(new ActionListener() {
159159
public void actionPerformed(ActionEvent e) {
160160
handleRunDevice();
161161
}
162162
});
163163

164-
JMenuItem presentItem = Toolkit.newJMenuItemShift(AndroidToolbar.getTitle(AndroidToolbar.RUN, true), 'E');
164+
JMenuItem presentItem = Toolkit.newJMenuItemShift(AndroidToolbar.getTitle(AndroidToolbar.RUN_IN_EMULATOR), 'E');
165165
presentItem.addActionListener(new ActionListener() {
166166
public void actionPerformed(ActionEvent e) {
167167
handleRunEmulator();
168168
}
169169
});
170170

171-
JMenuItem stopItem = new JMenuItem(AndroidToolbar.getTitle(AndroidToolbar.STOP, false));
171+
JMenuItem stopItem = new JMenuItem(AndroidToolbar.getTitle(AndroidToolbar.STOP));
172172
stopItem.addActionListener(new ActionListener() {
173173
public void actionPerformed(ActionEvent e) {
174174
handleStop();

mode/src/processing/mode/android/AndroidToolbar.java

+17-26
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,17 @@
3939

4040
@SuppressWarnings("serial")
4141
public class AndroidToolbar extends EditorToolbar {
42-
static protected final int RUN = 0;
43-
static protected final int STOP = 1;
42+
static protected final int RUN_ON_DEVICE = 0;
43+
static protected final int RUN_IN_EMULATOR = 1;
44+
static protected final int STOP = 2;
4445

45-
static protected final int NEW = 2;
46-
static protected final int OPEN = 3;
47-
static protected final int SAVE = 4;
48-
static protected final int EXPORT_PACKAGE = 5;
49-
static protected final int EXPORT_BUNDLE = 6;
50-
static protected final int EXPORT_PROJECT = 7;
46+
static protected final int NEW = 3;
47+
static protected final int OPEN = 4;
48+
static protected final int SAVE = 5;
49+
50+
static protected final int EXPORT_PACKAGE = 6;
51+
static protected final int EXPORT_BUNDLE = 7;
52+
static protected final int EXPORT_PROJECT = 8;
5153

5254

5355
private AndroidEditor aEditor;
@@ -61,25 +63,14 @@ public AndroidToolbar(Editor editor, Base base) {
6163
}
6264

6365

64-
// TODO:
65-
// Buttons are initialized in createButtons, see code of EditorToolbar.rebuild()
66-
// public void init() {
67-
// Image[][] images = loadImages();
68-
// for (int i = 0; i < 6; i++) {
69-
// addButton(getTitle(i, false), getTitle(i, true), images[i], i == NEW);
70-
// }
71-
// }
72-
73-
74-
static public String getTitle(int index, boolean shift) {
66+
static public String getTitle(int index) {
7567
switch (index) {
76-
case RUN: return !shift ? "Run on Device" : "Run in Emulator";
77-
case STOP: return "Stop";
78-
case NEW: return "New";
79-
case OPEN: return "Open";
80-
case SAVE: return "Save";
81-
82-
68+
case RUN_ON_DEVICE: return AndroidMode.getTextString("menu.sketch.run_on_device");
69+
case RUN_IN_EMULATOR: return AndroidMode.getTextString("menu.sketch.run_in_emulator");
70+
case STOP: return AndroidMode.getTextString("menu.sketch.stop");
71+
case NEW: return AndroidMode.getTextString("menu.file.new");
72+
case OPEN: return AndroidMode.getTextString("menu.file.open");
73+
case SAVE: return AndroidMode.getTextString("menu.file.save");
8374
case EXPORT_PACKAGE: return AndroidMode.getTextString("menu.file.export_signed_package");
8475
case EXPORT_BUNDLE: return AndroidMode.getTextString("menu.file.export_signed_bundle");
8576
case EXPORT_PROJECT: return AndroidMode.getTextString("menu.file.export_android_project");

0 commit comments

Comments
 (0)