Skip to content

Commit b6df9ea

Browse files
committed
Remove CompiledName attributes,
fix some xml docs, fix Chart.withSlider/s not having an append argument
1 parent ceb2a4b commit b6df9ea

File tree

5 files changed

+78
-151
lines changed

5 files changed

+78
-151
lines changed

src/Plotly.NET.CSharp/ChartAPI/Chart.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public static partial class Chart
2020
/// </summary>
2121
/// <param name="gCharts">the charts to combine</param>
2222
/// <returns></returns>
23-
public static GenericChart Combine(IEnumerable<GenericChart> gCharts) => Plotly.NET.Chart.Combine(gCharts);
23+
public static GenericChart Combine(IEnumerable<GenericChart> gCharts) => Plotly.NET.Chart.combine(gCharts);
2424

2525
/// <summary>
2626
/// Creates a chart that is completely invisible when rendered. The Chart object however is NOT empty! Combining this chart with other charts will have unforseen consequences (it has for example invisible axes that can override other axes if used in Chart.Combine)

src/Plotly.NET.CSharp/GenericChartExtensions.cs

+10-10
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public static void SaveHtml(
3535
string path,
3636
Optional<bool> OpenInBrowser = default
3737
) =>
38-
Plotly.NET.Chart.SaveHtml(
38+
Plotly.NET.Chart.saveHtml(
3939
path: path,
4040
OpenInBrowser: OpenInBrowser.ToOption()
4141
).Invoke(gChart);
@@ -44,7 +44,7 @@ public static void SaveHtml(
4444
/// Saves the given chart as a temporary html file and opens it in the browser.
4545
/// </summary>
4646
/// <param name="gChart">The chart to show in the browser</param>
47-
public static void Show(this GenericChart gChart) => Plotly.NET.Chart.Show(gChart);
47+
public static void Show(this GenericChart gChart) => Plotly.NET.Chart.show(gChart);
4848

4949
/// <summary>
5050
/// Sets trace information on the given chart.
@@ -65,7 +65,7 @@ public static GenericChart WithTraceInfo(
6565
Optional<string> LegendGroup = default,
6666
Optional<Title> LegendGroupTitle = default
6767
) =>
68-
Plotly.NET.Chart.WithTraceInfo(
68+
Plotly.NET.Chart.withTraceInfo(
6969
Name: Name.ToOption(),
7070
Visible: Visible.ToOption(),
7171
ShowLegend: ShowLegend.ToOption(),
@@ -80,7 +80,7 @@ public static GenericChart WithSize(
8080
Optional<int> Width = default,
8181
Optional<int> Height = default
8282
) =>
83-
Plotly.NET.Chart.WithSize(Width: Width.ToOption(), Height: Height.ToOption()).Invoke(gChart);
83+
Plotly.NET.Chart.withSize(Width: Width.ToOption(), Height: Height.ToOption()).Invoke(gChart);
8484

8585
/// <summary>
8686
/// Sets the given x axis styles on the input chart's layout.
@@ -155,7 +155,7 @@ public static GenericChart WithXAxisStyle<MinType, MaxType, CategoryArrayType>(
155155
where MaxType : IConvertible
156156
where CategoryArrayType : IConvertible
157157
=>
158-
Plotly.NET.Chart.WithXAxisStyle<MinType, MaxType, CategoryArrayType>(
158+
Plotly.NET.Chart.withXAxisStyle<MinType, MaxType, CategoryArrayType>(
159159
TitleText: TitleText.ToOption(),
160160
TitleFont: TitleFont.ToOption(),
161161
TitleStandoff: TitleStandoff.ToOption(),
@@ -266,7 +266,7 @@ public static GenericChart WithYAxisStyle<MinType, MaxType, CategoryArrayType>(
266266
where MaxType : IConvertible
267267
where CategoryArrayType : IConvertible
268268
=>
269-
Plotly.NET.Chart.WithYAxisStyle<MinType, MaxType, CategoryArrayType>(
269+
Plotly.NET.Chart.withYAxisStyle<MinType, MaxType, CategoryArrayType>(
270270
TitleText: TitleText.ToOption(),
271271
TitleFont: TitleFont.ToOption(),
272272
TitleStandoff: TitleStandoff.ToOption(),
@@ -316,7 +316,7 @@ public static GenericChart WithMapbox(
316316
Optional<int> Id = default
317317
)
318318
=>
319-
Plotly.NET.Chart.WithMapbox(
319+
Plotly.NET.Chart.withMapbox(
320320
mapbox: mapbox,
321321
Id: Id.ToOption()
322322
).Invoke(gChart);
@@ -374,7 +374,7 @@ public static GenericChart WithXAxisRangeSlider(
374374
Optional<StyleParam.SubPlotId> Id = default
375375
)
376376
=>
377-
Plotly.NET.Chart.WithXAxisRangeSlider(
377+
Plotly.NET.Chart.withXAxisRangeSlider(
378378
rangeSlider: rangeSlider,
379379
Id: Id.ToOption()
380380
).Invoke(gChart);
@@ -393,7 +393,7 @@ public static GenericChart WithLegend(
393393
Optional<int> Id
394394
)
395395
=>
396-
Plotly.NET.Chart.WithLegend(
396+
Plotly.NET.Chart.withLegend(
397397
legend: legend,
398398
Id: Id.ToOption()
399399
).Invoke(gChart);
@@ -460,7 +460,7 @@ public static GenericChart WithLegendStyle(
460460
Optional<int> Id = default
461461
)
462462
=>
463-
Plotly.NET.Chart.WithLegendStyle(
463+
Plotly.NET.Chart.withLegendStyle(
464464
BGColor: BGColor.ToOption(),
465465
BorderColor: BorderColor.ToOption(),
466466
BorderWidth: BorderWidth.ToOption(),

0 commit comments

Comments
 (0)