Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 9fd0cd8

Browse files
pinepainpinepain
committed
Fix false-positive v8 6.3 valgrind reports, closes #47 
1 parent 8fc173f commit 9fd0cd8

File tree

140 files changed

+334
-128
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+334
-128
lines changed

Diff for: ‎.valgrind-v8.supp

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
<suppress_false_positive_warning_see_v8_issue_6566>
3+
Memcheck:Cond
4+
fun:_ZN2v88internal20MarkCompactCollector20EmptyMarkingWorklistEv
5+
...
6+
}

Diff for: ‎.valgrindrc

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--gen-suppressions=all
2+
--suppressions=./.valgrind-v8.supp

Diff for: ‎tests/001-extension_info.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
v8 extension info
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/001-verify-method-case.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check whether all methods follows naming convention
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
$re = new ReflectionExtension('v8');

Diff for: ‎tests/001-verify-methods-signature.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check whether methods signature is valid
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
$re = new ReflectionExtension('v8');

Diff for: ‎tests/001-verify_extension_entities.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
Check whether all method parameters have valid type
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/001.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check for v8 presence
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
echo "v8 extension is available";

Diff for: ‎tests/002-enums.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
Built-in enum classes
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/003-V8ObjectTemplate_recursive_chain.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate - recursive 2
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/003-V8ObjectTemplate_recursive_global.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/003-V8ObjectTemplate_recursive_self.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate::set() - recursive self
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/003-V8ObjectTemplate_recursive_tree.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate::set() - recursive tree
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/004-ICU-Intl_dateTimeFormat.phpt

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ ICU - Intl.DateTimeFormat()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
55
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
67
TZ=UTC
78
--INI--
89
date.timezone = "UTC"

Diff for: ‎tests/004-ICU-Intl_numberFormat.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
ICU - Intl.NumberFormat()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/005-V8FunctionTemplate_external_memory.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\FunctionTemplate - external memory
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/005-V8ObjectTemplate_external_memory.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate - external memory
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/005-V8ObjectValue_external_memory.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectValue - external memory
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/010-no-value-self-cleanup-on-shutdown.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
Built-in enum classes
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/ArrayObject.phpt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
V8\ArrayObject
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) { print "skip"; } ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/ArrayObject_length.phpt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
V8\ArrayObject::length()
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) { print "skip"; } ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Boolean.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\BooleanValue
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/BooleanObject.phpt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
V8\BooleanObject
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) { print "skip"; } ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/CachedData.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ScriptCompiler\CachedData
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Context.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Context
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Context_globalObject.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Context::globalObject()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Context_invalid_ctor_arg_type.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Context::__construct() - with invalid arg type
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Context_reference_lifecycle.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
V8\Context reference lifecycle
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/Context_setSecurityToken.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Context::setSecurityToken()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/Context_weakness.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
V8\Context weakness
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

Diff for: ‎tests/Data.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Data
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/DateObject.phpt

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
--TEST--
22
V8\DateObject
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
75
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
87
TZ=UTC
98
--INI--
109
date.timezone = "UTC"

Diff for: ‎tests/ExceptionManager_createCreateMessage.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createCreateMessage()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createError.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createError()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createGetStackTrace.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createGetStackTrace()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createRangeError.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createRangeError()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createReferenceError.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createReferenceError()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createSyntaxError.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createSyntaxError()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionManager_createTypeError.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ExceptionManager::createTypeError()
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
/** @var \Phpv8Testsuite $helper */

Diff for: ‎tests/ExceptionsTryCatchException.phpt

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\Exceptions\TryCatchException
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

Diff for: ‎tests/FunctionCallbackInfo.phpt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
V8\FunctionCallbackInfo
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

0 commit comments

Comments
 (0)