Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute bind-element should take an optional bind-value #497

Closed
g105b opened this issue Nov 7, 2024 · 0 comments · Fixed by #498
Closed

Attribute bind-element should take an optional bind-value #497

g105b opened this issue Nov 7, 2024 · 0 comments · Fixed by #498
Assignees
@g105b
Labels
enhancement

Comments

@g105b
Copy link
Member

g105b commented Nov 7, 2024

On the automatically remove unbound elements docs, it shows the following example:

<div data-element data-bind:text="error">Error message goes here</div>

It would actually be really nice if we could supply the bind key to the data-element attribute instead, in case we just want to use the binding process to toggle an element's presence:

<div data-element="error">This only shows if "error" is bound</div>
@g105b g105b self-assigned this Nov 7, 2024
@g105b g105b mentioned this issue Nov 7, 2024
Open
@g105b g105b linked a pull request Nov 21, 2024 that will close this issue
feature: allow binding directly to data-element #498
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: allow binding directly to data-element phpgt/DomTemplate
1 participant
@g105b