Skip to content

[Symfony] Symfony 3.3 / 4.x compatibility for ProxyEventDispatcher #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkarlovi opened this issue Jun 7, 2017 · 2 comments · Fixed by #129
Closed

[Symfony] Symfony 3.3 / 4.x compatibility for ProxyEventDispatcher #109

dkarlovi opened this issue Jun 7, 2017 · 2 comments · Fixed by #129
Labels
bug

Comments

@dkarlovi
Copy link
Contributor

dkarlovi commented Jun 7, 2017

On Symfony 3.3, I'm getting an error:

The "Enqueue\Bundle\Events\ProxyEventDispatcher" class extends "Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher" that is deprecated since 3.3, to be removed in 4.0. Use EventDispatcher with closure factories instead.
@makasim makasim added the bug label Jun 7, 2017
@makasim
Copy link
Member

makasim commented Jun 7, 2017

What can I say? it has to be fixed.

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Jun 7, 2017

Yeah, but seeing Symfony 4 is almost half a year away, it's not really high priority. :)

@makasim makasim mentioned this issue Jul 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bundle] Extend EventDispatcher instead of container aware one. php-enqueue/enqueue-dev
2 participants
@makasim @dkarlovi