Parenthesised ConstructorCallExpression and ConstantExpressions failing to parse with Groovy 2

[BrendanHart]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v8.49.0
• Gradle plugin v7.3.0
• rewrite-groovy v8.49.0
• Gradle 6.9.1

How are you running OpenRewrite?

Originally I found this bug whilst using the Gradle plugin with Gradle 6, but have since reproduced with a test.

What is the smallest, simplest way to reproduce the problem?

Added the below to GroovyParserTest in the Groovy 2 test suite:

    @Test
    void shouldBeAbleToParseParenthesisedConstructorCallExpressions() {
        rewriteRun(
            groovy(
                """
                (new BigDecimal(10))
                """
            )
        );
    }

    @Test
    void shouldBeAbleToParseParenthesisedConstantExpressions() {
        rewriteRun(
                groovy(
                        """
                        (100)
                        """
                )
        );
    }

What did you expect to see?

The tests pass.

What did you see instead?

The tests fail.

What is the full stack trace of any errors you encountered?

expected: "(new BigDecimal(10))"
 but was: "new(10w BigDecimal(10))"

expected: "(100)"
 but was: "1000)"

Are you interested in contributing a fix to OpenRewrite?

Yes

[timtebeek]

Great to now finally have that Groovy 2 test suite; should help unambiguously finding and fixing such issues, thanks!

[BrendanHart]

Updated as it seems to be more general than just assignment, and also covering other expression types.