Skip to content

Commit a198e24

Browse files
JckXiaJckXia
authoredJun 10, 2023
[Test] Add tests for async progress queue worker (#1316)
* test: Add tests for async progress queue worker * Fix PR suggestions
1 parent 665f4aa commit a198e24

File tree

2 files changed

+289
-0
lines changed

2 files changed

+289
-0
lines changed
 

Diff for: ‎test/async_progress_queue_worker.cc

+155
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,158 @@ struct ProgressData {
1515
int32_t progress;
1616
};
1717

18+
class TestWorkerWithNoCb : public AsyncProgressQueueWorker<ProgressData> {
19+
public:
20+
static void DoWork(const CallbackInfo& info) {
21+
switch (info.Length()) {
22+
case 1: {
23+
Function cb = info[0].As<Function>();
24+
TestWorkerWithNoCb* worker = new TestWorkerWithNoCb(info.Env(), cb);
25+
worker->Queue();
26+
} break;
27+
28+
case 2: {
29+
std::string resName = info[0].As<String>();
30+
Function cb = info[1].As<Function>();
31+
TestWorkerWithNoCb* worker =
32+
new TestWorkerWithNoCb(info.Env(), resName.c_str(), cb);
33+
worker->Queue();
34+
} break;
35+
36+
case 3: {
37+
std::string resName = info[0].As<String>();
38+
Object resObject = info[1].As<Object>();
39+
Function cb = info[2].As<Function>();
40+
TestWorkerWithNoCb* worker =
41+
new TestWorkerWithNoCb(info.Env(), resName.c_str(), resObject, cb);
42+
worker->Queue();
43+
} break;
44+
45+
default:
46+
47+
break;
48+
}
49+
}
50+
51+
protected:
52+
void Execute(const ExecutionProgress& progress) override {
53+
ProgressData data{1};
54+
progress.Send(&data, 1);
55+
}
56+
57+
void OnProgress(const ProgressData*, size_t /* count */) override {
58+
_cb.Call({});
59+
}
60+
61+
private:
62+
TestWorkerWithNoCb(Napi::Env env, Function cb)
63+
: AsyncProgressQueueWorker(env) {
64+
_cb.Reset(cb, 1);
65+
}
66+
TestWorkerWithNoCb(Napi::Env env, const char* resourceName, Function cb)
67+
: AsyncProgressQueueWorker(env, resourceName) {
68+
_cb.Reset(cb, 1);
69+
}
70+
TestWorkerWithNoCb(Napi::Env env,
71+
const char* resourceName,
72+
const Object& resourceObject,
73+
Function cb)
74+
: AsyncProgressQueueWorker(env, resourceName, resourceObject) {
75+
_cb.Reset(cb, 1);
76+
}
77+
FunctionReference _cb;
78+
};
79+
80+
class TestWorkerWithRecv : public AsyncProgressQueueWorker<ProgressData> {
81+
public:
82+
static void DoWork(const CallbackInfo& info) {
83+
switch (info.Length()) {
84+
case 2: {
85+
Object recv = info[0].As<Object>();
86+
Function cb = info[1].As<Function>();
87+
TestWorkerWithRecv* worker = new TestWorkerWithRecv(recv, cb);
88+
worker->Queue();
89+
} break;
90+
91+
case 3: {
92+
Object recv = info[0].As<Object>();
93+
Function cb = info[1].As<Function>();
94+
std::string resName = info[2].As<String>();
95+
TestWorkerWithRecv* worker =
96+
new TestWorkerWithRecv(recv, cb, resName.c_str());
97+
worker->Queue();
98+
} break;
99+
100+
case 4: {
101+
Object recv = info[0].As<Object>();
102+
Function cb = info[1].As<Function>();
103+
std::string resName = info[2].As<String>();
104+
Object resObject = info[3].As<Object>();
105+
TestWorkerWithRecv* worker =
106+
new TestWorkerWithRecv(recv, cb, resName.c_str(), resObject);
107+
worker->Queue();
108+
} break;
109+
110+
default:
111+
112+
break;
113+
}
114+
}
115+
116+
protected:
117+
void Execute(const ExecutionProgress&) override {}
118+
119+
void OnProgress(const ProgressData*, size_t /* count */) override {}
120+
121+
private:
122+
TestWorkerWithRecv(const Object& recv, const Function& cb)
123+
: AsyncProgressQueueWorker(recv, cb) {}
124+
TestWorkerWithRecv(const Object& recv,
125+
const Function& cb,
126+
const char* resourceName)
127+
: AsyncProgressQueueWorker(recv, cb, resourceName) {}
128+
TestWorkerWithRecv(const Object& recv,
129+
const Function& cb,
130+
const char* resourceName,
131+
const Object& resourceObject)
132+
: AsyncProgressQueueWorker(recv, cb, resourceName, resourceObject) {}
133+
};
134+
135+
class TestWorkerWithCb : public AsyncProgressQueueWorker<ProgressData> {
136+
public:
137+
static void DoWork(const CallbackInfo& info) {
138+
switch (info.Length()) {
139+
case 1: {
140+
Function cb = info[0].As<Function>();
141+
TestWorkerWithCb* worker = new TestWorkerWithCb(cb);
142+
worker->Queue();
143+
} break;
144+
145+
case 2: {
146+
Function cb = info[0].As<Function>();
147+
std::string asyncResName = info[1].As<String>();
148+
TestWorkerWithCb* worker =
149+
new TestWorkerWithCb(cb, asyncResName.c_str());
150+
worker->Queue();
151+
} break;
152+
153+
default:
154+
155+
break;
156+
}
157+
}
158+
159+
protected:
160+
void Execute(const ExecutionProgress&) override {}
161+
162+
void OnProgress(const ProgressData*, size_t /* count */) override {}
163+
164+
private:
165+
TestWorkerWithCb(Function cb) : AsyncProgressQueueWorker(cb) {}
166+
TestWorkerWithCb(Function cb, const char* res_name)
167+
: AsyncProgressQueueWorker(cb, res_name) {}
168+
};
169+
18170
class TestWorker : public AsyncProgressQueueWorker<ProgressData> {
19171
public:
20172
static Napi::Value CreateWork(const CallbackInfo& info) {
@@ -87,6 +239,9 @@ Object InitAsyncProgressQueueWorker(Env env) {
87239
Object exports = Object::New(env);
88240
exports["createWork"] = Function::New(env, TestWorker::CreateWork);
89241
exports["queueWork"] = Function::New(env, TestWorker::QueueWork);
242+
exports["runWorkerNoCb"] = Function::New(env, TestWorkerWithNoCb::DoWork);
243+
exports["runWorkerWithRecv"] = Function::New(env, TestWorkerWithRecv::DoWork);
244+
exports["runWorkerWithCb"] = Function::New(env, TestWorkerWithCb::DoWork);
90245
return exports;
91246
}
92247

Diff for: ‎test/async_progress_queue_worker.js

+134
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,144 @@ const common = require('./common');
44
const assert = require('assert');
55

66
module.exports = common.runTest(test);
7+
const nodeVersion = process.versions.node.split('.')[0];
8+
9+
let asyncHooks;
10+
function checkAsyncHooks () {
11+
if (nodeVersion >= 8) {
12+
if (asyncHooks === undefined) {
13+
asyncHooks = require('async_hooks');
14+
}
15+
return true;
16+
}
17+
return false;
18+
}
719

820
async function test ({ asyncprogressqueueworker }) {
921
await success(asyncprogressqueueworker);
1022
await fail(asyncprogressqueueworker);
23+
24+
await asyncProgressWorkerCallbackOverloads(asyncprogressqueueworker.runWorkerWithCb);
25+
await asyncProgressWorkerRecvOverloads(asyncprogressqueueworker.runWorkerWithRecv);
26+
await asyncProgressWorkerNoCbOverloads(asyncprogressqueueworker.runWorkerNoCb);
27+
}
28+
29+
async function asyncProgressWorkerCallbackOverloads (bindingFunction) {
30+
bindingFunction(common.mustCall());
31+
if (!checkAsyncHooks()) {
32+
return;
33+
}
34+
35+
const hooks = common.installAysncHooks('cbResources');
36+
37+
const triggerAsyncId = asyncHooks.executionAsyncId();
38+
await new Promise((resolve, reject) => {
39+
bindingFunction(common.mustCall(), 'cbResources');
40+
hooks.then(actual => {
41+
assert.deepStrictEqual(actual, [
42+
{
43+
eventName: 'init',
44+
type: 'cbResources',
45+
triggerAsyncId: triggerAsyncId,
46+
resource: {}
47+
},
48+
{ eventName: 'before' },
49+
{ eventName: 'after' },
50+
{ eventName: 'destroy' }
51+
]);
52+
resolve();
53+
}).catch((err) => reject(err));
54+
});
55+
}
56+
57+
async function asyncProgressWorkerRecvOverloads (bindingFunction) {
58+
const recvObject = {
59+
a: 4
60+
};
61+
62+
function cb () {
63+
assert.strictEqual(this.a, recvObject.a);
64+
}
65+
66+
bindingFunction(recvObject, common.mustCall(cb));
67+
if (!checkAsyncHooks()) {
68+
return;
69+
}
70+
const asyncResources = [
71+
{ resName: 'cbRecvResources', resObject: {} },
72+
{ resName: 'cbRecvResourcesObject', resObject: { foo: 'bar' } }
73+
];
74+
75+
for (const asyncResource of asyncResources) {
76+
const asyncResName = asyncResource.resName;
77+
const asyncResObject = asyncResource.resObject;
78+
79+
const hooks = common.installAysncHooks(asyncResource.resName);
80+
const triggerAsyncId = asyncHooks.executionAsyncId();
81+
await new Promise((resolve, reject) => {
82+
if (Object.keys(asyncResObject).length === 0) {
83+
bindingFunction(recvObject, common.mustCall(cb), asyncResName);
84+
} else {
85+
bindingFunction(recvObject, common.mustCall(cb), asyncResName, asyncResObject);
86+
}
87+
88+
hooks.then(actual => {
89+
assert.deepStrictEqual(actual, [
90+
{
91+
eventName: 'init',
92+
type: asyncResName,
93+
triggerAsyncId: triggerAsyncId,
94+
resource: asyncResObject
95+
},
96+
{ eventName: 'before' },
97+
{ eventName: 'after' },
98+
{ eventName: 'destroy' }
99+
]);
100+
resolve();
101+
}).catch((err) => reject(err));
102+
});
103+
}
104+
}
105+
106+
async function asyncProgressWorkerNoCbOverloads (bindingFunction) {
107+
bindingFunction(common.mustCall());
108+
if (!checkAsyncHooks()) {
109+
return;
110+
}
111+
const asyncResources = [
112+
{ resName: 'noCbResources', resObject: {} },
113+
{ resName: 'noCbResourcesObject', resObject: { foo: 'bar' } }
114+
];
115+
116+
for (const asyncResource of asyncResources) {
117+
const asyncResName = asyncResource.resName;
118+
const asyncResObject = asyncResource.resObject;
119+
120+
const hooks = common.installAysncHooks(asyncResource.resName);
121+
const triggerAsyncId = asyncHooks.executionAsyncId();
122+
await new Promise((resolve, reject) => {
123+
if (Object.keys(asyncResObject).length === 0) {
124+
bindingFunction(asyncResName, common.mustCall(() => {}));
125+
} else {
126+
bindingFunction(asyncResName, asyncResObject, common.mustCall(() => {}));
127+
}
128+
129+
hooks.then(actual => {
130+
assert.deepStrictEqual(actual, [
131+
{
132+
eventName: 'init',
133+
type: asyncResName,
134+
triggerAsyncId: triggerAsyncId,
135+
resource: asyncResObject
136+
},
137+
{ eventName: 'before' },
138+
{ eventName: 'after' },
139+
{ eventName: 'destroy' }
140+
]);
141+
resolve();
142+
}).catch((err) => reject(err));
143+
});
144+
}
11145
}
12146

13147
function success (binding) {

0 commit comments

Comments
 (0)