-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to set an optional logout url when using the environment variable authentication #114
Comments
Ok. Good point :-) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So, adding
to logout function here: makes the url Our use case is using https://github.com/soudis/discoursesso to sign in to our Discourse instance from Nextcloud. We would like to make sure users log out from Nextcloud when they log out from Discourse. Discourse allows in its settings to direct a user to a specific URL after logout - which Nextcloud does not allow. Probably a better (but still hackish) solution is here: https://help.nextcloud.com/t/how-can-i-write-my-own-logout-page/14676 P.S. Half a year later: if you setup discourse logout url to https://YOUR_NEXTCLOUD_INSTANCE/index.php/apps/discoursesso/logout , it starts working. |
In some case, when using the environment variable (ie. with CAS), a specific logout url is required to actually logout of nextcloud.
Allowing the admin to optionally set a custom logout url would actually allow a complete implementation of some SSO like CAS. Indeed, until this is possible, users won't be able to logout not until their CAS session actually expires (or until the user closes the browser) which is dangerous.
The text was updated successfully, but these errors were encountered: