Skip to content

fix: don't shadow netlify functions #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2024
Merged

fix: don't shadow netlify functions #115

merged 1 commit into from
May 27, 2024

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented May 27, 2024

Resolves #114

@Skn0tt Skn0tt self-assigned this May 27, 2024
@Skn0tt Skn0tt requested a review from lukasholzer May 27, 2024 11:50
@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 27, 2024
@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit e87da64
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/66547369d955ff0008c087dd
😎 Deploy Preview https://deploy-preview-115--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Skn0tt Skn0tt requested a review from ascorbic May 27, 2024 11:50
serhalp
serhalp approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔂

@serhalp serhalp merged commit 9fb04f9 into main May 27, 2024
14 checks passed
@serhalp serhalp deleted the dont-shadow-functions branch May 27, 2024 13:29
@token-generator-app token-generator-app bot mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhalp serhalp serhalp approved these changes

@lukasholzer lukasholzer Awaiting requested review from lukasholzer

@ascorbic ascorbic Awaiting requested review from ascorbic

Assignees

@Skn0tt Skn0tt

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use normal Netlify functions when SSR enabled
2 participants
@Skn0tt @serhalp