Skip to content

Commit 5843bc8

Browse files
authored
fix: excludedPath contained relative paths for some prerendered static files (#74)
* fix: correctly generate excludedPath + add test setup * fix: remove --serve now that netlify/cli#6138 landed * fix: prettier * fix: update node version * fix: for some reason, `--offline` doesn't infer the build command * fix: update minimum node version to 18.13.0, to align with Angular CLI See https://github.com/angular/cli-builds/blob/1f309514d9f8d81fb2dfbcb163b554d79394a67c/bin/ng.js#L64# Please enter the commit message for your changes. Lines starting * fix: excludedPath should always be posix
1 parent e6fab5f commit 5843bc8

File tree

8 files changed

+38265
-4713
lines changed

8 files changed

+38265
-4713
lines changed

Diff for: .github/workflows/test.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [ubuntu-latest, macOS-latest, windows-latest]
15-
node-version: [10.13.0, '*']
15+
node-version: [18.13.0, '*']
1616
exclude:
1717
- os: macOS-latest
18-
node-version: 10.13.0
18+
node-version: 18.13.0
1919
- os: windows-latest
20-
node-version: 10.13.0
20+
node-version: 18.13.0
2121
fail-fast: false
2222

2323
steps:

Diff for: README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Keep in mind that these will not be available on the client-side or during [prer
7474
To test this in local development, run your Angular project using `netlify serve`:
7575

7676
```sh
77-
netlify serve --dir dist/<your-project-name>/browser
77+
netlify serve
7878
```
7979

8080
## CLI Usage

Diff for: demo.test.mjs

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import assert from 'node:assert'
2+
import { test } from 'node:test'
3+
4+
test('edge function config', async () => {
5+
const { config } = await import('./demo/.netlify/edge-functions/angular-ssr/angular-ssr.mjs')
6+
7+
assert.deepEqual(config.excludedPath, [
8+
'/dashboard/index.html',
9+
'/favicon.ico',
10+
'/heroes/index.html',
11+
'/index.html',
12+
'/main-UUT7SL5W.js',
13+
'/polyfills-LZBJRJJE.js',
14+
'/styles-5INURTSO.css',
15+
'/dashboard',
16+
'/heroes',
17+
])
18+
})

Diff for: demo/netlify.toml

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
[build]
2+
command="npm run build"
23
ignore="exit 1" ## always build, there might be changes in the plugin
34

45
[[plugins]]

Diff for: demo/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)