Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change show/hide grid key in map editor #1085

Closed
paul59 opened this issue May 14, 2020 · 4 comments · Fixed by #1088
Closed

Suggestion: Change show/hide grid key in map editor #1085

paul59 opened this issue May 14, 2020 · 4 comments · Fixed by #1088
Assignees
Labels
editor: map Issues related to map editor

Comments

@paul59
Copy link
Contributor

paul59 commented May 14, 2020

Would it make more sense to change the show/hide grid shortcut from ` (back-tick) to # (hash) as this matches the symbol at the top of the window for this feature?

@nesbox
Copy link
Owner

nesbox commented May 15, 2020

to get # you have to press shift+3 on my keyboard, don't think it's more convenient than just one button

@paul59
Copy link
Contributor Author

paul59 commented May 15, 2020

to get # you have to press shift+3 on my keyboard, don't think it's more convenient than just one button

Fair point I wasn't thinking about the convenience, just the association of the symbol with the key. What about changing the symbol [icon] from '#' to

image

@nesbox
Copy link
Owner

nesbox commented May 15, 2020

Could you pls change it yourself here

static const u8 GridIcon[] =

I'll approve your pull request

@paul59
Copy link
Contributor Author

paul59 commented May 15, 2020

Done

@paul59 paul59 closed this as completed May 15, 2020
@nesbox nesbox linked a pull request May 15, 2020 that will close this issue
@nesbox nesbox added the editor: map Issues related to map editor label May 15, 2020
@nesbox nesbox added this to the 0.80.0 milestone May 15, 2020
@nesbox nesbox removed this from the 0.80.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: map Issues related to map editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants