Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified version on site is broken #357

Closed
punkman opened this issue Oct 25, 2018 · 3 comments
Closed

Minified version on site is broken #357

punkman opened this issue Oct 25, 2018 · 3 comments

Comments

@punkman
Copy link

punkman commented Oct 25, 2018

Minified file linked on the site in the section "Download - Browser global" is broken, Debug version is fine.

I think the version is, 1.4.4, the last one.
With debug version I get a regular DateTime string with min version I see 'shortTshort'.

If needed here a JSFiddle to test it: https://jsfiddle.net/gsey7hdu/

Probably I'm one of the last guys around not using a packet manager/preprocessor :)
Thanks

@icambron
Copy link
Member

Yikes, that is not good.

@icambron
Copy link
Member

Seems to be some sort of issue in the minifier. I have no idea how to even investigate it, though. I think I'll try some experiments with using the minifier directly, but I'm kinda shooting in the dark.

@icambron
Copy link
Member

I fixed this by uglifying the file directly instead of using the Rollup plugin. This isn't a great solution and I really need to fix the root issue, but I'm not sure how to tackle that, and the quick fix sure beats having a broken build.

In the meantime, issues include:

  • Does the scriptmap work as expected?
  • The file is a little bigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants