Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adopting a new ini grammar #141632

Open
alexr00 opened this issue Jan 27, 2022 · 3 comments
Open

Consider adopting a new ini grammar #141632

alexr00 opened this issue Jan 27, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Jan 27, 2022

We get our ini syntax highlighting grammar from textmate/ini.tmbundle. Upstream issue: textmate/ini.tmbundle#2

@alexr00

Hello,
since I'm also facing this issue constantly (also with ' char) I've checked the linked repository and it seems that is completely abandoned - the last commit is from 9 years ago and none of the submitted PR's was merged. This indicates that the problem/bug might persist forever.

If the ini syntax highlighting grammar was taken from this repo a long time ago then why it can't be fixed/updated by VSCode team? Can you re-open this issue and suggest a new approach how to fix it?

Originally posted by @ALIENQuake in #139531 (comment)

@alexr00 alexr00 added feature-request Request for new features or functionality grammar Syntax highlighting grammar labels Jan 27, 2022
@alexr00 alexr00 added this to the Backlog milestone Jan 27, 2022
@alexr00 alexr00 self-assigned this Jan 27, 2022
@alexr00
Copy link
Member Author

alexr00 commented Jan 27, 2022

@ALIENQuake it's hard for a smallish team like the VS Code team to be experts in every language we want to provide syntax highlighting for, so we won't be updating the grammar ourselves. However, we've had several abandoned grammar repos in recent years that members of the community have offered well maintained alternatives for (a1481e3, #115480, and #140489). If the owner of a well maintained ini textmate grammar asks that we try using their grammar instead then I'd be happy to consider adopting it!

In the mean time maybe there is an extension you can install that will provide better syntax highlighting for your ini files. As a last resort, you can disable the built in ini extension too.

@ALIENQuake
Copy link

@alexr00 I have new code for ini grammar that fixes ' bug. Does having a separate repository is required of I could simply send PR?

@alexr00
Copy link
Member Author

alexr00 commented Jan 31, 2022

@ALIENQuake a separate repository is required. Some evidence that the new grammar will continue to be maintained is also very helpful (for example, a history of maintaining the grammar as part of an extension).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar
Projects
None yet
Development

No branches or pull requests

2 participants