Skip to content

TestIncludeFileNoExecutions is Flaky in go-sqlcmd v1.8.2 #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertakman opened this issue Feb 21, 2025 · 1 comment
Open

TestIncludeFileNoExecutions is Flaky in go-sqlcmd v1.8.2 #565

mertakman opened this issue Feb 21, 2025 · 1 comment
Labels

Comments

@mertakman
Copy link

mertakman commented Feb 21, 2025

Environment

  • Go version: 1.22.0
  • go-sqlcmd version: 1.8.2
  • Operating System: Ubuntu 22.04
  • Database Server: SQL Server 2017

How to reproduce

After starting SQL Server 2017 with its credentials on Docker:

docker run -m 2GB -e ACCEPT_EULA=1 -d --name {{ .Env.SQL_SERVER_NAME }} -p:1433:1433 -e SA_PASSWORD={{ .Env.SQLCMDPASSWORD }} mcr.microsoft.com/mssql/server:2017-latest

I'm running the test in Ubuntu 22.04 with:

go test -timeout 30s -run ^TestIncludeFileNoExecutions$

Issue Description

The test TestIncludeFileNoExecutions in go-sqlcmd v1.8.2 is flaky, sometimes failing inconsistently.

Workaround

Currently we are skipping this test with:

go test -skip=^TestIncludeFileNoExecutions$
@gdams gdams added the testing label Feb 21, 2025
@shueybubbles
Copy link
Collaborator

unfortunately I think there's a race condition in go-mssqldb at the root of it. It passes most of the time.

@mertakman mertakman changed the title TestIncludeFileNoExecutions is failing TestIncludeFileNoExecutions is Flaky in go-sqlcmd v1.8.2 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants