bug: Symlinked model files should not be deleted

[mtomas7]

Jan version

0.5.14

Describe the Bug

When you load a model file you are presented with two options:

• one option to symlink the model file
• another option is to copy model file to Jan's folder.

If you select symlink option, it's like saying "I have a model library, do not touch my files, just link to them". But when it comes to deleting model from Jan, you only have one option and that option is to delete model and it would actually delete symlinked model files - not good!

It is not a good way to handle this because if you already decided that you want to symlink file, that means there should be another option which just unlinks that model file not deletes it:

• Start Model
• Delete Model
• Unlink Model

Perhaps it should be handled automatically and for linked model only "Unlink Model" option will be displayed.

Thank you!

Steps to Reproduce

No response

Screenshots / Logs

No response

What is your OS?

• MacOS
• Windows
• Linux

[louis-menlo]

Thanks for flagging this up! @mtomas7

[imtuyethan]

• PR: fix: models.cc: symlinked model deletion shouldn't remove original file #1918

[louis-menlo]

Delivered, Jan 0.5.15 - Cortex 1.0.10