Skip to content

Commit 85f376d

Browse files
committed
Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy' and drops support for 'auto', a=testonly
Automatic update from web-platform-tests The syntax of the 'justify-items' property accepts a new 'legacy' value, replacing the 'auto' value which is now parsed as invalid. w3c/csswg-drafts#1318 This change affects also to the 'place-items' shorthand, which doesn't accept 'auto' and, for the time being, neither 'legacy'. Link to the intent-to-ship-and-remove request: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer Bug: 726147, 726148 Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350 Reviewed-on: https://chromium-review.googlesource.com/903162 Commit-Queue: Javier Fernandez <jfernandezigalia.com> Reviewed-by: Christian Biesinger <cbiesingerchromium.org> Reviewed-by: Darren Shen <shendchromium.org> Cr-Commit-Position: refs/heads/master{#535593} <!-- Reviewable:start --> <!-- Reviewable:end --> wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f wpt-pr: 9400 reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead UltraBlame original commit: 340be2f71abf82d0de28870cdfa987e0e309e267
1 parent 348a39e commit 85f376d

File tree

4 files changed

+28
-11
lines changed

4 files changed

+28
-11
lines changed

Diff for: testing/web-platform/meta/MANIFEST.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -475796,7 +475796,7 @@
475796475796
"testharness"
475797475797
],
475798475798
"css/css-align/content-distribution/place-content-shorthand-004.html": [
475799-
"5aa5cda5b2b0204bd2deb5c813532f394644b31f",
475799+
"17c135945710d209b2e410d36867f6244ac358a0",
475800475800
"testharness"
475801475801
],
475802475802
"css/css-align/content-distribution/place-content-shorthand-005.html": [
@@ -475844,7 +475844,7 @@
475844475844
"testharness"
475845475845
],
475846475846
"css/css-align/default-alignment/parse-justify-items-002.html": [
475847-
"b74652a3770f5bf8b7184748d62a21625f9121b3",
475847+
"12902e19304a7f02a52c576f3daf72fd9eb45ff8",
475848475848
"testharness"
475849475849
],
475850475850
"css/css-align/default-alignment/parse-justify-items-003.html": [
@@ -475876,7 +475876,7 @@
475876475876
"testharness"
475877475877
],
475878475878
"css/css-align/default-alignment/place-items-shorthand-004.html": [
475879-
"d4b6346f68b085a297ba5b15a5803258cbf661da",
475879+
"51b0eff81deca9f5e056f5db1d49f3e9be80435b",
475880475880
"testharness"
475881475881
],
475882475882
"css/css-align/default-alignment/place-items-shorthand-005.html": [

Diff for: testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html

+6
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@
4747
checkInvalidValues("start auto")
4848
}, "Verify 'auto' values are invalid");
4949

50+
test(function() {
51+
checkInvalidValues("self-start")
52+
checkInvalidValues("center self-end")
53+
checkInvalidValues("self-end start")
54+
}, "Verify self-position values are invalid");
55+
5056
test(function() {
5157
checkInvalidValues("")
5258
}, "Verify empty declaration is invalid");

Diff for: testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html

+7-7
Original file line numberDiff line numberDiff line change
@@ -19,39 +19,39 @@
1919
test(function() {
2020
element = document.createElement("div");
2121
document.body.appendChild(element);
22-
checkValues(element, "justifyItems", "justify-items", "", "legacy");
22+
checkValues(element, "justifyItems", "justify-items", "", "normal");
2323
}, "Test 'initial' value when nothing is specified");
2424

2525
test(function() {
2626
container.style.display = "";
27-
checkInitialValues(element, "justifyItems", "justify-items", "center", "legacy");
27+
checkInitialValues(element, "justifyItems", "justify-items", "center", "normal");
2828
}, "Test justify-items: 'initial'");
2929

3030
test(function() {
3131
container.style.display = "grid";
32-
checkInitialValues(element, "justifyItems", "justify-items", "safe start", "legacy");
32+
checkInitialValues(element, "justifyItems", "justify-items", "safe start", "normal");
3333
}, "Test grid items justify-items: 'initial'");
3434

3535
test(function() {
3636
container.style.display = "flex";
37-
checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "legacy");
37+
checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "normal");
3838
}, "Test flex items justify-items: 'initial'");
3939

4040
test(function() {
4141
container.style.display = "";
4242
element.style.position = "absolute";
43-
checkInitialValues(element, "justifyItems", "justify-items", "start", "legacy");
43+
checkInitialValues(element, "justifyItems", "justify-items", "start", "normal");
4444
}, "Test absolute positioned elements justify-items: 'initial'");
4545

4646
test(function() {
4747
container.style.display = "grid";
4848
element.style.position = "absolute";
49-
checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy");
49+
checkInitialValues(element, "justifyItems", "justify-items", "end", "normal");
5050
}, "Test absolute positioned grid items justify-items: 'initial'");
5151

5252
test(function() {
5353
container.style.display = "flex";
5454
element.style.position = "absolute";
55-
checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy");
55+
checkInitialValues(element, "justifyItems", "justify-items", "end", "normal");
5656
}, "Test absolute positioned flex items justify-items: 'initial'");
5757
</script>

Diff for: testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html

+12-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,18 @@
3737
checkInvalidValues("auto")
3838
checkInvalidValues("auto right")
3939
checkInvalidValues("auto auto")
40-
}, "Verify 'auto' value is invalid as first longhand value.");
40+
checkInvalidValues("center auto")
41+
}, "Verify 'auto' value is invalid.");
42+
43+
test(function() {
44+
checkInvalidValues("legacy")
45+
checkInvalidValues("legacy start")
46+
checkInvalidValues("end legacy")
47+
checkInvalidValues("legacy left")
48+
checkInvalidValues("center legacy")
49+
checkInvalidValues("start legacy center")
50+
}, "Verify 'legacy' value is invalid.");
51+
4152

4253
test(function() {
4354
checkInvalidValues("")

0 commit comments

Comments
 (0)