You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the input parameter parsing is sub-optimal. All the arguments are also noted as keywords and the input parameters are only parsed once. However, if autocorr==1, then the X2/Y2/Z2 arrays are not required. This causes issue with passing None as the X2/Y2/Z2 arrays from the python wrappers. Correct solution would be to parse the arguments once with positional args only and then parse the arguments again based on the entire keywords list. This parsing might need to use a different keyword list based on the value of autocorr.
The changes will have to be made in python_bindings for both theory and mocks.
The text was updated successfully, but these errors were encountered:
Currently the input parameter parsing is sub-optimal. All the arguments are also noted as keywords and the input parameters are only parsed once. However, if
autocorr==1
, then theX2/Y2/Z2
arrays are not required. This causes issue with passingNone
as theX2/Y2/Z2
arrays from the python wrappers. Correct solution would be to parse the arguments once with positional args only and then parse the arguments again based on the entire keywords list. This parsing might need to use a different keyword list based on the value ofautocorr
.The changes will have to be made in
python_bindings
for boththeory
andmocks
.The text was updated successfully, but these errors were encountered: