Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve args and keyword parsing in extensions #79

Closed
manodeep opened this issue Sep 14, 2016 · 2 comments
Closed

Improve args and keyword parsing in extensions #79

manodeep opened this issue Sep 14, 2016 · 2 comments
Milestone

Comments

@manodeep
Copy link
Owner

manodeep commented Sep 14, 2016

Currently the input parameter parsing is sub-optimal. All the arguments are also noted as keywords and the input parameters are only parsed once. However, if autocorr==1, then the X2/Y2/Z2 arrays are not required. This causes issue with passing None as the X2/Y2/Z2 arrays from the python wrappers. Correct solution would be to parse the arguments once with positional args only and then parse the arguments again based on the entire keywords list. This parsing might need to use a different keyword list based on the value of autocorr.

The changes will have to be made in python_bindings for both theory and mocks.

@manodeep manodeep modified the milestones: v2.0, v2.1 Sep 14, 2016
@manodeep
Copy link
Owner Author

This really is an issue when the user tries to use the extension directly, rather than going through the corresponding python wrapper within Corrfunc.

@manodeep
Copy link
Owner Author

manodeep commented Sep 4, 2017

Since the user should really be only accessing the python wrappers to the extensions, and not the extensions directly, I am closing this.

@manodeep manodeep closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant