Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on setup.py command-line args to make #31

Closed
manodeep opened this issue Feb 18, 2016 · 2 comments
Closed

Pass on setup.py command-line args to make #31

manodeep opened this issue Feb 18, 2016 · 2 comments
Milestone

Comments

@manodeep
Copy link
Owner

Currently, python setup.py build just runs make under the hood but ignores command-line arguments. For instance, if the compiler is set in the command-line argument, then that compiler should be used. Should be straightforward as calling make argv, once argv has been parsed

@manodeep manodeep added this to the v1.0 milestone Apr 2, 2016
@manodeep
Copy link
Owner Author

manodeep commented Apr 9, 2016

Looks like this is much more difficult! Essentially, people have to do export CC = gcc before calling python setup.py install. In any case, all of the compilation is handled in the Makefile, and users should first make and then make install anyway.

Will make some simple attempts to test before closing this issue.

@manodeep manodeep modified the milestones: v1.0, v2.0 Apr 16, 2016
@manodeep
Copy link
Owner Author

manodeep commented Aug 4, 2016

Fixed with 4b44511. Compiler can now be specified like so python setup.py install CC=/usr/bin/gcc

@manodeep manodeep closed this as completed Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant