-
Notifications
You must be signed in to change notification settings - Fork 257
FSQ implementations' bug #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ah yes, i see it the reason is bc it was transcribed from the pseudocode in the paper ![]() @fab-jul do you have any thoughts? |
#95 will merge if author confirms this is an error |
Hi yes this is a mistake, should be arctanh. Note that it barely matters as it's called with a value around 0, where both are similar. Also note that the whole |
@fab-jul yea i figured as i hear from a lot of people having success with FSQ! let me get this merged in just for correctness sake @scenarios thank you for spotting this |
Your implementation on bound function might be incorrect.
tan() is not the inverse of tanh().
The text was updated successfully, but these errors were encountered: