Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to not limit parameters? #23

Closed
dougwilson opened this issue Aug 26, 2014 · 2 comments
Closed

Ability to not limit parameters? #23

dougwilson opened this issue Aug 26, 2014 · 2 comments
Assignees
Milestone

Comments

@dougwilson
Copy link
Contributor

So I just noticed this when comparing the options of qs to querystring: querystring accepts 0 or Infinity to say no limit on the keys (though it by default has no limit). Providing either of those two values to this module results in an empty parse. I'm not sure if you want to support those (the 0 thing seems dumb to indicate "no limit", but whatever), but thought I'd bring it up :)

@nlf nlf added this to the 2.1.1 milestone Aug 26, 2014
@nlf nlf self-assigned this Aug 26, 2014
@nlf
Copy link
Collaborator

nlf commented Aug 26, 2014

I agree that 0 to denote unlimited is silly, but I'll make sure that Infinity works correctly.

@nlf nlf closed this as completed in b147f46 Aug 26, 2014
@dougwilson
Copy link
Contributor Author

you rock 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants