adding some proxy validation and logs

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>

Author: matthyx

utils/http_proxy.go

@@ -6,11 +6,14 @@ import (
 	"bufio"
 	"context"
 	"fmt"
-	"golang.org/x/net/proxy"
 	"net"
 	"net/http"
 	"net/url"
 	"os"
+
+	"github.com/kubescape/go-logger"
+	"github.com/kubescape/go-logger/helpers"
+	"golang.org/x/net/proxy"
 )
 
 type direct struct{}
@@ -35,10 +38,12 @@ func newHTTPProxy(uri *url.URL, forward proxy.Dialer) (proxy.Dialer, error) {
 	s := new(httpProxy)
 	s.host = uri.Host
 	s.forward = forward
+	logger.L().Info("setting proxy", helpers.String("scheme", uri.Scheme), helpers.String("host", s.host))
 	if uri.User != nil {
 		s.haveAuth = true
 		s.username = uri.User.Username()
 		s.password, _ = uri.User.Password()
+		logger.L().Info("setting basic auth for proxy", helpers.String("username", s.username), helpers.Int("len(password)", len(s.password)))
 	}
 
 	return s, nil
@@ -107,19 +112,21 @@ func GetDialer() func(context.Context, string, string) (net.Conn, error) {
 	for _, envVar := range envVars {
 		if httpProxy := os.Getenv(envVar); httpProxy != "" {
 			uri, err := url.Parse(httpProxy)
-			if err == nil {
-				proxyURI = uri
+			if err != nil {
+				logger.L().Fatal("failed to parse proxy URI", helpers.Error(err))
 			}
+			proxyURI = uri
 		}
 	}
 	// default proxy net dial
 	proxyNetDial := proxy.FromEnvironment()
 	// if custom URI is defined, generate proxy net dial from that
 	if proxyURI != nil {
 		dial, err := proxy.FromURL(proxyURI, Direct)
-		if err == nil {
-			proxyNetDial = dial
+		if err != nil {
+			logger.L().Fatal("failed to create proxy dialer", helpers.Error(err))
 		}
+		proxyNetDial = dial
 	}
 	// return dialer as a net.DialContext function
 	return func(ctx context.Context, a, b string) (net.Conn, error) {