-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wildcards in whitelist attributes #1871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was going to be about wildcards, but it is framed around a new method for data- / custom "data" attributes. attributes. On review of the issue I still lean towards a wildcard match. Like 'data-' or 'ng-' etc. I think that will be more flexible and simpler to use than another method. It can be implemented in the isSafeAttribute method, doesn't need another data structure to retain them,
Fixed. |
Sorry for the late reply. I'm not moving ahead with this, as I think the implementation can be simpler, as I suggested in my earlier comment. |
Support validation on data attributes.